yade-dev team mailing list archive

[Václav Šmilauer <eudoxos@xxxxxxxx>]

Vincent, thanks for your code, but a few remarks:

1. Capitalize the class name (BasicVTKWriter)
2. Fix spelling, probably it should be BasicVTKWriter
3. Consider some different name; we've had many "basic", "simple"
classes and I doubt it was ever name that told something. Wouldn't
something like CellVTKWriter or TextVTKWriter be better?

Cheers, Vaclav
> ------------------------------------------------------------
> revno: 1963
> committer: Vincent Richefeu <richefeu@macbook-pro-de-vincent-richefeu.local>
> branch nick: trunk
> timestamp: Tue 2010-01-12 15:35:36 +0100
> message:
>   Rewrite KinematicLocalisationAnalyser::DefToFile for vtk format.
> modified:
>   lib/triangulation/KinematicLocalisationAnalyser.cpp
>   lib/triangulation/basicVTKwritter.cpp