yade-dev team mailing list archive

[Václav Šmilauer <eudoxos@xxxxxxxx>]

Eh, no problem :-) 

As your law is still not a LawFunctor but an engine, you can name it
RockJointContactLaw, or perhaps just RockJointLaw. But I strongly
suggest that you convert it to a LawFunctor (i.e. you just use the
inside of the loop), then it whould be called
Law2_ScGeom_RockJointPhys_RockJoint, provided ContactLaw1Interaction is
also renamed to RockJointPhys, for instance.

Use the scripts/rename-class.py as I suggested earlier, it will save you
most (all) manual typing work.

> By the way, I afford to me to say that, from my point of view, I always 
> saw very very few meaningful names in yade... What about "ef2" in 
> ef2_Dem3Dof_NormalShear_ElasticFrictionalLaw ? "ig2" in 
> Ig2_Box_Sphere_ScGeom ?...
See https://www.yade-dem.org/sphinx/prog.html#class-naming for naming
functors and explanation of those prefixes.

Good point, though,  ef2_Dem3Dof_NormalShear_ElasticFrictionalLaw should
be named differently, like Law2_Dem3Dof_NormalShear_ElastFrict or such.
Still getting things being a little consistent.

Once you are in that, make sure you document all your classes properly.
No-one would guess ContactLaw1 is rock-joint law, I think.

Thanks for cooperation, Vaclav.