← Back to team overview

yade-dev team mailing list archive

Re: [Branch ~yade-dev/yade/trunk] Rev 2374: 1. Do not uselessly pass Scene* pointer to Law2 functors (already in LawFunctor)

 


Le 17/07/2010 19:39, noreply@xxxxxxxxxxxxx a écrit :
------------------------------------------------------------
revno: 2374
committer: Václav Šmilauer<eudoxos@xxxxxxxx>
branch nick: trunk
timestamp: Sat 2010-07-17 19:37:54 +0200
message:
   1. Do not uselessly pass Scene* pointer to Law2 functors (already in LawFunctor)
Hello Vaclav,

Are you really sure (I dare the question) of that ? Because that is exactly this kind of change which let my scripts crash recently (when I was thinking first it was du to ScGeom's changes) :
- without Scene* in Law2::go, it crashed
- with Scene* in Law2::go, it did not crash anymore.
See http://www.mail-archive.com/yade-dev@xxxxxxxxxxxxxxxxxxx/msg04803.html and http://www.mail-archive.com/yade-dev@xxxxxxxxxxxxxxxxxxx/msg04797.html and http://www.mail-archive.com/yade-dev@xxxxxxxxxxxxxxxxxxx/msg04802.html

I did not try yet with this version (where you changed LawFunctor.hpp itself - but not NormalInelasticityLaw.h/cpp in fact). I can do it if you want.

Jerome



Follow ups

References