yade-dev team mailing list archive

[Anton Gladky <gladky.anton@xxxxxxxxx>]

Hi Bruno,

I have committed a fix, which from my point of view
is more correct than the current implementation. CMake
generates hpp and ipp files for every other cpp to escape
function/classes redefinitions.

We can use again -DCHUNKSIZE=10 without any problems.

For any new PFV-engine you just need to add a new entry
in cmake to generate its own hpp and ipp files [2].

Feedback is welcome.

[1] https://github.com/yade/trunk/commit/6357a8a5e299d7f4231d36d11d059d4cb94816e8
[2] https://github.com/yade/trunk/blob/master/CMakeLists.txt#L505

Cheers

Anton


2014-06-19 13:38 GMT+02:00 Bruno Chareyre <bruno.chareyre@xxxxxxxxxxx>:
> Yes of course, else it would not need templates.
> There are 4 different flow engines already. 3 of them are in pkg/pfv
> (Flow, PeriodicFlow, DFNFlow) and one of them is only in a separate
> (Chao's) git branch.
> We can discuss design improvement in Grenoble, there may be ways.
>
> Bruno