← Back to team overview

yade-dev team mailing list archive

Re: Please: we don't want compile warnings

 

Hi,

I think it makes sense to enable "warnung-as-errors" for buildbot-builds.
So the build will fail if new warnings were introduced in the last commits.

Something like:

cmake -DCMAKE_CXX_FLAGS="-Werror -Wall" ../src/to/yade

Of course one need to fix all warnings before switching it on hardly.

Anton


2017-11-02 13:38 GMT+01:00 Bruno Chareyre <bruno.chareyre@xxxxxxxxxxxxxxx>:
> Hi all,
> I've seen an increase of compile warnings after some commits in the last
> months (members of the blamelist in bcc of this message ;)).
> I would like to recall that compile warnings should be considered like bugs
> and be fixed.
> Please make sure there is no compile warning before pushing code to trunk,
> and if some code you previously pushed gives some please fix.
> Warnings reveal real problems sometimes, and they clutter the compile logs
> always.
> If you are not sure how to fix some of them (e.g. the award-winning
> "comparison between signed and unsigned") you can ask on yade-dev.
> Cheers
> Bruno
>
>
>
> --
> _______________
> Bruno Chareyre
> Associate Professor
> ENSE³ - Grenoble INP
> Lab. 3SR
> BP 53
> 38041 Grenoble cedex 9
> Tél : +33 4 56 52 86 21
> Fax : +33 4 76 82 70 43
> ________________
>
> Email too brief?
> Here's why! http://emailcharter.org
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~yade-dev
> Post to     : yade-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~yade-dev
> More help   : https://help.launchpad.net/ListHelp


Follow ups

References