yade-dev team mailing list archive

[Anton Gladky <gladky.anton@xxxxxxxxx>]

Hello,

I would vote for the option with merge requests. Yade
has enough core developers to review, comment and
accept those requests. And it is not a problem if the MR
will take 2-3 days for the review process.

In this case one can see in the GitLab-pipeline, whether the code
compiles, tests passed, documentation is not broken and many
additional checks, which can improve the code quality.

My 2 cts

Anton

Am Di., 11. Dez. 2018 um 17:04 Uhr schrieb Bruno Chareyre
<bruno.chareyre@xxxxxxxxxxxxxxx>:
>
>
>
> On 12/5/18 7:21 AM, Klaus Thoeni wrote:
> > I terms of branching, I think this should be kept flexible. I think
> > branches make sense if you work on major changes. However, I still
> > think main devs should be able to push directly to the trunk,
> > obviously with care ;-)
> I think we need to distinguish two aspects:
> 1- do we "push" or do we "request-merge"?
> 2- who is allowed to accept the merge requests?
>
> I don't see a real need to use direct push (point 1), one exception is
> when fixing simple bugs maybe.
> What you say is more  (I guess) that some devs need enough rights to
> accept their own MR (point 2). Right?
>
> Bruno
>
>
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~yade-dev
> Post to     : yade-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~yade-dev
> More help   : https://help.launchpad.net/ListHelp