yade-users team mailing list archive
-
yade-users team
-
Mailing list archive
-
Message #03882
Re: I think it should be a bug in the code of some constitutive model
Hi Luc,
Thank you so much for your reply. I am appreciate that you wrote the constitutive model is so clear. It is easy to understand. Thank you again.
Cheers
Liqing
At 2010-11-18 14:23:58,"luc scholtes" <lscholtes63@xxxxxxxxx> wrote:
Hi Jiao,
Thank you for your email. I think you are right, it should be written
ratio=MomentMax/scalarMoment;
instead of
ratio *= MomentMax/scalarMoment; // to fix the moment to its yielding value
It is always good to have someone behind your shoulders to avoid this kind of error ;-)
Feel free to commit the change. Otherwise I will try to do it ASAP.
Luc
2010/11/17 jiaoliqing<jiaoliqing@xxxxxxx>
Hi Luc Scholtes,
I have read the code in CohesiveFrictionalPM.cpp written by you. I read them carefully, so I found there would be a bug in the file. In the part of description of moment, this part of code is as followed:
/*Plastic moment */
if(scalarMoment > MomentMax)
{
Real ratio = 0;
ratio *= MomentMax/scalarMoment; // to fix the moment to its yielding value
moment *= ratio;
moment_twist *= ratio;
moment_bending *= ratio;
}
Furthermore, the same code is in CohesionlessMomentRotation.cpp to calculate the moment when the moment is over the plastic limit. It is distinct bug that is " ratio *= MomentMax/scalarMoment;". it is written as this, then the ratio will still be zero during the simulation. Then the moment will be zero in the plastic stage. That is different from the algorithms. So, this one should be changed to "ratio = MomentMax/scalarMoment;", others don't need to modify. Do you agree with me?
Look forward your reply. thank you!
Regards
Liqing
网易163/126邮箱百分百兼容iphone ipad邮件收发
_______________________________________________
Mailing list:https://launchpad.net/~yade-users
Post to :yade-users@xxxxxxxxxxxxxxxxxxx
Unsubscribe :https://launchpad.net/~yade-users
More help :https://help.launchpad.net/ListHelp
References