← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1182075] Re: TypeError for cinder problems

 

** Changed in: horizon/grizzly
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1182075

Title:
  TypeError for cinder problems

Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in OpenStack Dashboard (Horizon) grizzly series:
  Fix Released

Bug description:
  If cinder does not report correctly, Horizon raises TypeError.

  Look at:

      def _get_volumes(self, search_opts=None):
          try:
              return cinder.volume_list(self.request, search_opts=search_opts)
          except:
              exceptions.handle(self.request,
                                _('Unable to retrieve volume list.'))

  If an exception is raised, it will return None. Then in
  openstack_dashboard/dashboards/admin/volumes/views.py we have:

      def get_volumes_data(self):
          volumes = self._get_volumes(search_opts={'all_tenants': 1})
          ...
          for volume in volumes:
              tenant_id = getattr(volume, "os-vol-tenant-attr:tenant_id", None)

  and a TypeError will be raised because one cannot iterate through
  None.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1182075/+subscriptions