yahoo-eng-team team mailing list archive

[Daniel Berrange <1261827@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The code within each virt driver's directory nova/virt/XXXX/ is
considered to be private to that virt driver.

The baremetal driver, however, imports and depends on libvirt volume
driver code

$ grep libvirt volume_driver.py
from nova.virt.libvirt import utils as libvirt_utils
CONF.import_opt('volume_drivers', 'nova.virt.libvirt.driver', group='libvirt')
            self._initiator = libvirt_utils.get_iscsi_initiator()
    """The VolumeDriver delegates to nova.virt.libvirt.volume."""
        for driver_str in CONF.libvirt.volume_drivers:

If this code truly is useful to multiple drivers, then it should be in
common shared code. Virt drivers should never directly use each other's
private code.

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1261827

Title:
   Bare metal virt driver depends libvirt volume driver code

Status in OpenStack Compute (Nova):
  New

Bug description:
  The code within each virt driver's directory nova/virt/XXXX/ is
  considered to be private to that virt driver.

  The baremetal driver, however, imports and depends on libvirt volume
  driver code

  $ grep libvirt volume_driver.py
  from nova.virt.libvirt import utils as libvirt_utils
  CONF.import_opt('volume_drivers', 'nova.virt.libvirt.driver', group='libvirt')
              self._initiator = libvirt_utils.get_iscsi_initiator()
      """The VolumeDriver delegates to nova.virt.libvirt.volume."""
          for driver_str in CONF.libvirt.volume_drivers:

  If this code truly is useful to multiple drivers, then it should be in
  common shared code. Virt drivers should never directly use each
  other's private code.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1261827/+subscriptions