yahoo-eng-team team mailing list archive

[Daniel Berrange <1261826@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The code within each virt driver's directory nova/virt/XXXX/ is
considered to be private to that virt driver.

The baremetal driver, however, imports and depends on libvirt image
caching code

$ grep imagecache driver.py
from nova.virt.libvirt import imagecache
        "has_imagecache": True,
        self.image_cache_manager = imagecache.ImageCacheManager()

$ grep libvirt utils.py
from nova.virt.libvirt import utils as libvirt_utils
        libvirt_utils.fetch_image(context, target, image_id,


If this code truly is useful to multiple drivers, then it should be in common shared code. Virt drivers should never directly use each other's private code.

** Affects: nova
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1261826

Title:
  Bare metal virt driver depends libvirt image caching code

Status in OpenStack Compute (Nova):
  New

Bug description:
  The code within each virt driver's directory nova/virt/XXXX/ is
  considered to be private to that virt driver.

  The baremetal driver, however, imports and depends on libvirt image
  caching code

  $ grep imagecache driver.py
  from nova.virt.libvirt import imagecache
          "has_imagecache": True,
          self.image_cache_manager = imagecache.ImageCacheManager()

  $ grep libvirt utils.py
  from nova.virt.libvirt import utils as libvirt_utils
          libvirt_utils.fetch_image(context, target, image_id,

  
  If this code truly is useful to multiple drivers, then it should be in common shared code. Virt drivers should never directly use each other's private code.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1261826/+subscriptions