← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1281483] [NEW] i18n info lost in fedora's rpm spec cause build failed

 

Public bug reported:

It might not should be reported here, but I couldn't find fedora's bug
tracker.

The rpm spec file is in in http://pkgs.fedoraproject.org/cgit/python-django-horizon.git/ (el6-havana)
when build the rpm pakages, it throws
===============
error: can't copy 'horizon/locale/en/LC_MESSAGES/django.po': doesn't exist or not a regular file
error: Bad exit status from /var/tmp/rpm-tmp.UMUzma (%build)
===============

That's because in openstack we have MANIFEST.in which defined
---------------
recursive-include openstack_dashboard
---------------

However in fedora's  http://pkgs.fedoraproject.org/cgit/python-django-horizon.git/tree/python-django-horizon.spec?h=el6-havana L167:
----
# remove unnecessary .po files
find . -name "django*.po" -exec rm -f '{}' \;
----
which deleted the i18n files. As a result when we using fedora's spec file build rpm package,  it follow MANIFEST.in to copy files to package which files had been deleted in the previous scripts.

Knowing the reason, it's easy to fix it. 2 solutions:
1. delete the "remove" scripts and add 	below info in the %files
%{python_sitelib}/horizon/locale/??/LC_MESSAGES/
%{python_sitelib}/horizon/locale/??_??/LC_MESSAGES/
2. Apply a patch when build package which edit the MANIFEST.in file.

Please guys from redhat confirm it.

** Affects: horizon
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1281483

Title:
  i18n info lost in fedora's rpm spec cause build failed

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  It might not should be reported here, but I couldn't find fedora's bug
  tracker.

  The rpm spec file is in in http://pkgs.fedoraproject.org/cgit/python-django-horizon.git/ (el6-havana)
  when build the rpm pakages, it throws
  ===============
  error: can't copy 'horizon/locale/en/LC_MESSAGES/django.po': doesn't exist or not a regular file
  error: Bad exit status from /var/tmp/rpm-tmp.UMUzma (%build)
  ===============

  That's because in openstack we have MANIFEST.in which defined
  ---------------
  recursive-include openstack_dashboard
  ---------------

  However in fedora's  http://pkgs.fedoraproject.org/cgit/python-django-horizon.git/tree/python-django-horizon.spec?h=el6-havana L167:
  ----
  # remove unnecessary .po files
  find . -name "django*.po" -exec rm -f '{}' \;
  ----
  which deleted the i18n files. As a result when we using fedora's spec file build rpm package,  it follow MANIFEST.in to copy files to package which files had been deleted in the previous scripts.

  Knowing the reason, it's easy to fix it. 2 solutions:
  1. delete the "remove" scripts and add 	below info in the %files
  %{python_sitelib}/horizon/locale/??/LC_MESSAGES/
  %{python_sitelib}/horizon/locale/??_??/LC_MESSAGES/
  2. Apply a patch when build package which edit the MANIFEST.in file.

  Please guys from redhat confirm it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1281483/+subscriptions


Follow ups

References