← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1353188] [NEW] [Bootstrap] error message box is transparent when modal dialog box is not closed

 

Public bug reported:

If the implementation of a form uses the following pattern to handle
exception:

         except Exception:
            exceptions.handle(request,
                              _('Unable to create volume type.'))
            return False

When exception happens , the modal dialog stays , and upper right corner
of the browser will have an error box which has a wrong styling. It is
transparent , not red.

I found issue during my implementation using the above pattern...but my
code is not in master yet...

this is how I reproduce the issue within current master code base:

to force exception: alter admin/volumes/volumes/forms.py and change the
api call to use None...

alter code like :  volume_type = cinder.volume_type_create(request,
                                                    None)

 go to admin , volumes to create volume type,  give any name...you
should see the problem.

** Affects: horizon
     Importance: Undecided
         Status: New

** Attachment added: "exception2.docx"
   https://bugs.launchpad.net/bugs/1353188/+attachment/4170753/+files/exception2.docx

** Description changed:

  If the implementation of a form uses the following pattern to handle
  exception:
  
- 
-          except Exception:
-             exceptions.handle(request,
-                               _('Unable to create volume type.'))
-             return False
+          except Exception:
+             exceptions.handle(request,
+                               _('Unable to create volume type.'))
+             return False
  
  When exception happens , the modal dialog stays , and upper right corner
  of the browser will have an error box which has a wrong styling. It is
  transparent , not red.
  
  I found issue during my implementation using the above pattern...but my
  code is not in master yet...
  
  this is how I reproduce the issue within current master code base:
  
  to force exception: alter admin/volumes/volumes/forms.py and change the
  api call to use None...
  
-  go to admin , volumes to create volume type,  give any name...you
+ alter code like :  volume_type = cinder.volume_type_create(request,
+                                                     None)
+ 
+  go to admin , volumes to create volume type,  give any name...you
  should see the problem.

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1353188

Title:
  [Bootstrap] error message box is transparent when modal dialog box is
  not closed

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  If the implementation of a form uses the following pattern to handle
  exception:

           except Exception:
              exceptions.handle(request,
                                _('Unable to create volume type.'))
              return False

  When exception happens , the modal dialog stays , and upper right
  corner of the browser will have an error box which has a wrong
  styling. It is transparent , not red.

  I found issue during my implementation using the above pattern...but
  my code is not in master yet...

  this is how I reproduce the issue within current master code base:

  to force exception: alter admin/volumes/volumes/forms.py and change
  the api call to use None...

  alter code like :  volume_type = cinder.volume_type_create(request,
                                                      None)

   go to admin , volumes to create volume type,  give any name...you
  should see the problem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1353188/+subscriptions


Follow ups

References