yahoo-eng-team team mailing list archive

[Tomáš Nováčik <tnovacik@xxxxxxxxxx>]

Public bug reported:

There is flaw in horizon integration test design, certain methods
located in the pageobject(those methods interact with webelements)
should be executed only in the scope of class and definitely not touched
in the test case. Problem is that those methods are public and thus
nothing suggest that those methods should not be used in a test
case(accessed as public method of page).  Therefore i suggest to make
those methods protected(make them start with the '_'  prefix).

List of methods:  is_element_visible,  fill_field_element,
select_dropdown,  select_dropdown_by_value

** Affects: horizon
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1356774

Title:
  Integration tests - selenium - public/private methods design flaw

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  There is flaw in horizon integration test design, certain methods
  located in the pageobject(those methods interact with webelements)
  should be executed only in the scope of class and definitely not
  touched in the test case. Problem is that those methods are public and
  thus nothing suggest that those methods should not be used in a test
  case(accessed as public method of page).  Therefore i suggest to make
  those methods protected(make them start with the '_'  prefix).

  List of methods:  is_element_visible,  fill_field_element,
  select_dropdown,  select_dropdown_by_value

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1356774/+subscriptions