yahoo-eng-team team mailing list archive

[Ian Cordasco <icordasc+launchpad@xxxxxxxxxx>]

Public bug reported:

In this generator [1] (nested in a for-loop) the middleware constantly
recreates the same tuple. This would perform better if two changes were
made:

1. Use a set instead of a tuple
2. Assign the set once outside of the for-loop saving several object creations. 

[1]:
https://github.com/openstack/horizon/blob/0f3192f84c872b1060ac6b7bbe1a3b34bbaf1b36/horizon/middleware.py#L179..L180

** Affects: horizon
     Importance: Undecided
     Assignee: Ian Cordasco (icordasc)
         Status: New

** Changed in: horizon
     Assignee: (unassigned) => Ian Cordasco (icordasc)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1359245

Title:
  Middleware creates tuple on every iteration of a loop

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  In this generator [1] (nested in a for-loop) the middleware constantly
  recreates the same tuple. This would perform better if two changes
  were made:

  1. Use a set instead of a tuple
  2. Assign the set once outside of the for-loop saving several object creations. 

  [1]:
  https://github.com/openstack/horizon/blob/0f3192f84c872b1060ac6b7bbe1a3b34bbaf1b36/horizon/middleware.py#L179..L180

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1359245/+subscriptions