yahoo-eng-team team mailing list archive

[Doug Fish <drfish@xxxxxxxxxx>]

Public bug reported:

We've had a number of review problems/escaped bugs related to the
handling of the environment_version in run_tests.sh.

The problem is that its an integer and it is supposed to increase
sequentially.  If there are multiple environment related patches out for
review in parallel only the first one will update the
environment_version.  The others will have their environment_version
successfully merge unless the developer or a reviewer noticed.

I plan to fix this by making the environment_version a string.  It takes
only a trivial change to the script to make this happen.  Then the
environment version can be the gerrit change number, possibly suffixed
with a "/2" or "/3" if there are multiple review patches.  This way the
environment_versions will not secretly resolve and patches can reliably
modify the environment_version.

** Affects: horizon
     Importance: Undecided
     Assignee: Doug Fish (drfish)
         Status: New

** Changed in: horizon
     Assignee: (unassigned) => Doug Fish (drfish)

** Description changed:

  We've had a number of review problems/escaped bugs related to the
  handling of the environment_version in run_tests.sh.
  
  The problem is that its an integer and it is supposed to increase
  sequentially.  If there are multiple environment related patches out for
  review in parallel only the first one will update the
  environment_version.  The others will have their environment_version
  successfully merge unless the developer or a reviewer noticed.
  
  I plan to fix this by making the environment_version a string.  It takes
  only a trivial change to the script to make this happen.  Then the
  environment version can be the gerrit change number, possibly suffixed
- with a "/1" or "/2" if there are multiple review patches.  This way the
+ with a "/2" or "/3" if there are multiple review patches.  This way the
  environment_versions will not secretly resolve and patches can reliably
  modify the environment_version.

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1376485

Title:
  Solidify environment_version handling in run_tests.sh

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  We've had a number of review problems/escaped bugs related to the
  handling of the environment_version in run_tests.sh.

  The problem is that its an integer and it is supposed to increase
  sequentially.  If there are multiple environment related patches out
  for review in parallel only the first one will update the
  environment_version.  The others will have their environment_version
  successfully merge unless the developer or a reviewer noticed.

  I plan to fix this by making the environment_version a string.  It
  takes only a trivial change to the script to make this happen.  Then
  the environment version can be the gerrit change number, possibly
  suffixed with a "/2" or "/3" if there are multiple review patches.
  This way the environment_versions will not secretly resolve and
  patches can reliably modify the environment_version.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1376485/+subscriptions