← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1403547] [NEW] flavor extra_specs are not passed to any of the filters

 

Public bug reported:

https://review.openstack.org/#/c/122557/7/nova/scheduler/utils.py broke
this by removing the 2 lines that would make sure extra_specs are dug up
from the DB before passing adding the instance_type to the request_spec,
which eventually get's passed as part of the filter_properties
(wrongfully, but that's a different bug) to all filters.

The fix is to either put this line back, or alternatively remove
instance_type from the update call here:

https://github.com/openstack/nova/blob/fec5ff129465ab35ca8cc37fa8dafd368233b7b6/nova/scheduler/filter_scheduler.py#L119

The consequence is that AggregateInstanceExtraSpecsFilter,
ComputeCapabilitiesFilter, TrustedFilter and trusted filters are broken
in master since cb338cb7692e12cc94515f1f09008d0e328c1505

** Affects: nova
     Importance: Critical
         Status: Confirmed


** Tags: scheduler

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1403547

Title:
  flavor extra_specs are not passed to any of the filters

Status in OpenStack Compute (Nova):
  Confirmed

Bug description:
  https://review.openstack.org/#/c/122557/7/nova/scheduler/utils.py
  broke this by removing the 2 lines that would make sure extra_specs
  are dug up from the DB before passing adding the instance_type to the
  request_spec, which eventually get's passed as part of the
  filter_properties (wrongfully, but that's a different bug) to all
  filters.

  The fix is to either put this line back, or alternatively remove
  instance_type from the update call here:

  https://github.com/openstack/nova/blob/fec5ff129465ab35ca8cc37fa8dafd368233b7b6/nova/scheduler/filter_scheduler.py#L119

  The consequence is that AggregateInstanceExtraSpecsFilter,
  ComputeCapabilitiesFilter, TrustedFilter and trusted filters are
  broken in master since cb338cb7692e12cc94515f1f09008d0e328c1505

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1403547/+subscriptions


Follow ups

References