← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1446021] [NEW] Remove get_admin_roles in neutron/policy.py

 

Public bug reported:

There is a comment in that method that clearly states its temporary
nature.


    # NOTE(salvatore-orlando): This function provides a solution for
    # populating implicit contexts with the appropriate roles so that
    # they correctly pass policy checks, and will become superseded
    # once all explicit policy checks are removed from db logic and
    # plugin modules. For backward compatibility it returns the literal
    # admin if ADMIN_CTX_POLICY is not defined

link:
http://git.openstack.org/cgit/openstack/neutron/tree/neutron/policy.py#n473

It is probably time function and all associated logic is removed - as it
constitutes a blocker for adoption of oslo_policy

** Affects: neutron
     Importance: High
     Assignee: Salvatore Orlando (salvatore-orlando)
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1446021

Title:
  Remove get_admin_roles in neutron/policy.py

Status in OpenStack Neutron (virtual network service):
  New

Bug description:
  There is a comment in that method that clearly states its temporary
  nature.

  
      # NOTE(salvatore-orlando): This function provides a solution for
      # populating implicit contexts with the appropriate roles so that
      # they correctly pass policy checks, and will become superseded
      # once all explicit policy checks are removed from db logic and
      # plugin modules. For backward compatibility it returns the literal
      # admin if ADMIN_CTX_POLICY is not defined

  link:
  http://git.openstack.org/cgit/openstack/neutron/tree/neutron/policy.py#n473

  It is probably time function and all associated logic is removed - as
  it constitutes a blocker for adoption of oslo_policy

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1446021/+subscriptions


Follow ups

References