yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem@xxxxxxxxxx>]

Public bug reported:

With this change we should be setting the microversion attribute on the
test API client for functional tests to hit microversions:

https://review.openstack.org/#/c/284257/

It's still possible to get around that by using the X-OpenStack-Nova-
API-Version header in the request that goes to the client.

For consistency, we should use the api.microversion attribute on the
test client.

As a test, we can see failures if we force that to change:

https://gist.github.com/mriedem/54c70579b52d26d80af9

It sounds like there are changes to make if we remove that support from
the functional tests and when we remove it, there is some code that was
built into the tests to enable it, which would be effectively dead code
so that would have to be removed at the same time.

This bug is just for tracking that cleanup TODO.

** Affects: nova
     Importance: Medium
         Status: Confirmed


** Tags: api functional testing

** Changed in: nova
       Status: New => Confirmed

** Changed in: nova
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1550709

Title:
  Stop using 'X-OpenStack-Nova-API-Version' header directly in
  functional tests

Status in OpenStack Compute (nova):
  Confirmed

Bug description:
  With this change we should be setting the microversion attribute on
  the test API client for functional tests to hit microversions:

  https://review.openstack.org/#/c/284257/

  It's still possible to get around that by using the X-OpenStack-Nova-
  API-Version header in the request that goes to the client.

  For consistency, we should use the api.microversion attribute on the
  test client.

  As a test, we can see failures if we force that to change:

  https://gist.github.com/mriedem/54c70579b52d26d80af9

  It sounds like there are changes to make if we remove that support
  from the functional tests and when we remove it, there is some code
  that was built into the tests to enable it, which would be effectively
  dead code so that would have to be removed at the same time.

  This bug is just for tracking that cleanup TODO.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1550709/+subscriptions