yahoo-eng-team team mailing list archive

[OpenStack Infra <1550709@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/292612
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=181cab5dc4ae8a00ac2125e455f12bdd2a62d357
Submitter: Jenkins
Branch:    master

commit 181cab5dc4ae8a00ac2125e455f12bdd2a62d357
Author: jichenjc <jichenjc@xxxxxxxxxx>
Date:   Thu Feb 25 20:51:06 2016 +0800

    avoid microversion header in functional test
    
    As a follow on of https://review.openstack.org/#/c/284257/
    Remove direct usage of X-OpenStack-Nova-API-Version
    in the header in 2 test class.
    Add a check in the api client so further direct use
    of header will raise an exception.
    
    Change-Id: I186a0396767c602e8c4a47089cc40a7c9bdffa40
    Closes-Bug: 1550709


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1550709

Title:
  Stop using 'X-OpenStack-Nova-API-Version' header directly in
  functional tests

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  With this change we should be setting the microversion attribute on
  the test API client for functional tests to hit microversions:

  https://review.openstack.org/#/c/284257/

  It's still possible to get around that by using the X-OpenStack-Nova-
  API-Version header in the request that goes to the client.

  For consistency, we should use the api.microversion attribute on the
  test client.

  As a test, we can see failures if we force that to change:

  https://gist.github.com/mriedem/54c70579b52d26d80af9

  It sounds like there are changes to make if we remove that support
  from the functional tests and when we remove it, there is some code
  that was built into the tests to enable it, which would be effectively
  dead code so that would have to be removed at the same time.

  This bug is just for tracking that cleanup TODO.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1550709/+subscriptions