yahoo-eng-team team mailing list archive

[OpenStack Infra <1595575@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/344334
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0ac7c988523f0112ec310deb4acd318cf6009bb8
Submitter: Jenkins
Branch:    master

commit 0ac7c988523f0112ec310deb4acd318cf6009bb8
Author: Balazs Gibizer <balazs.gibizer@xxxxxxxxxxxx>
Date:   Tue Jul 19 17:35:36 2016 +0200

    Notification object version test depends on SCHEMA
    
    As ObjectVersionChecker.test_hashes() supports extra_data_func parameter
    from ovo 2.6.0 this patch makes the notification object version test
    aware of the SCHEMA changes of the notification objects.
    
    The object hashes are updated without version bump as no real
    changes was made on the objects just the hash calculation is changed.
    
    Closes-Bug: #1595575
    Change-Id: I1375b43280d29026d7d1c0d362740d6077c5061f


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1595575

Title:
  The hash of a notification object does not depend on its SCHEMA

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Description
  ===========
  As oslo ObjectVersionChecker.test_hashes() does not provide a way to supply exta information to the fingerprint generation the current unit test does not detect if the SCHEMA of a versioned notification object has been changed without proper version bump. 

  Compare the unit test test_versions with
  test_notification_payload_version_depends_on_the_schema in
  TestNotificationObjectVersions [1]

  The former uses test_hashes without the extra_data_func while the
  later uses the get_hashes() with extra_data_func.

  [1]
  https://github.com/openstack/nova/blob/master/nova/tests/unit/notifications/objects/test_notification.py#L267

  Steps to reproduce
  ==================
  Modify the SCHEMA of one of the notification object. 
  Run the unit test
  SCHEMA changes are not detected

  Environment
  ===========
  6a119fc72096fa65678112e151e4a7a00091ce26

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1595575/+subscriptions