← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1744160] Re: Change in iso8601 0.1.12 date format breaks parsing with py35

 

Reviewed:  https://review.openstack.org/535520
Committed: https://git.openstack.org/cgit/openstack/oslo.versionedobjects/commit/?id=9c4aefb8ea88fd5505602c95f4762fdeb3aea183
Submitter: Zuul
Branch:    master

commit 9c4aefb8ea88fd5505602c95f4762fdeb3aea183
Author: Sean McGinnis <sean.mcginnis@xxxxxxxxxx>
Date:   Thu Jan 18 16:52:03 2018 -0600

    Handle TZ change in iso8601 >=0.1.12
    
    The iso8601 lib introduced a change such that if running on python
    3.2 or later it internally uses the python timezone information
    instead of its own implementation. This does not change direct
    date handling, but when converting this value there is a slight
    difference where now python 2.x will show UTC times as "UTC", but
    on python 3 they will end up with "UTC+00:00".
    
    The to_primitive call for DateTime fields was doing an exact match
    on "UTC" to determine whether to include "Z" in the resulting string.
    This updates that handling to recognize either of the new values.
    
    Change-Id: I71b58e8fd8fee8a57ee275ff3e0b77f165eca836
    Closes-bug: #1744160


** Changed in: oslo.versionedobjects
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1744160

Title:
  Change in iso8601 0.1.12 date format breaks parsing with py35

Status in Cinder:
  In Progress
Status in Glance:
  In Progress
Status in OpenStack Identity (keystone):
  New
Status in Manila:
  In Progress
Status in OpenStack Compute (nova):
  In Progress
Status in oslo.utils:
  In Progress
Status in oslo.versionedobjects:
  Fix Released

Bug description:
  New package of iso8601 returns string in the format:

  '2012-02-14T20:53:07UTC+00:00'

  instead of:

  
  '2012-02-14T20:53:07Z'

  
  This is resulting in date string comparison failures and timeutils.parse_isotime errors with:

  ValueError: Unable to parse date string '2014-08-08T00:00:00UTC+00:00'

To manage notifications about this bug go to:
https://bugs.launchpad.net/cinder/+bug/1744160/+subscriptions


References