yellow team mailing list archive

[Gary Poster <gary.poster@xxxxxxxxxxxxx>]

Reviewers: mp+133004_code.launchpad.net,

Message:
Please take a look.

Description:
Add related charms section to charm description

This adds a related charms section to the charm panel, per UX design.

It adds new functionality to the charm store find method in order to
make
the search efficient.

Tests for the view code are not factored as I had intended: I wanted
stubs to
test the composite functions in isolation. Kapil nixed this in favor of
test-all-the-way-through test functions as I have them here.

Thanks.

https://code.launchpad.net/~gary/juju-gui/relatedcharms/+merge/133004

(do not edit description out of merge proposal)


Please review this at https://codereview.appspot.com/6814089/

Affected files:
   A [revision details]
   M app/store/charm.js
   A app/templates/charm-description-related.handlebars
   M app/templates/charm-description.handlebars
   M app/views/charm-panel.js
   M lib/views/stylesheet.less
   M test/test_charm_panel.js
   M test/test_charm_store.js
   M undocumented



-- 
https://code.launchpad.net/~gary/juju-gui/relatedcharms/+merge/133004
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~gary/juju-gui/relatedcharms into lp:juju-gui.