yellow team mailing list archive

[Brad Crittenden <bac@xxxxxxxxxxxxx>]

Nice branch Thiago.  I've made a few comments about things to be tidied
up and a question about a small deviation from the visual design.  But
overall it looks good.


https://codereview.appspot.com/6733060/diff/5002/app/templates/service.handlebars
File app/templates/service.handlebars (right):

https://codereview.appspot.com/6733060/diff/5002/app/templates/service.handlebars#newcode14
app/templates/service.handlebars:14: <div class="inline
filter-label"><span>Filter</span></div>
The visual design has an eye ball image instead of the word 'Filter'.
Has the design changed?

https://codereview.appspot.com/6733060/diff/5002/lib/views/stylesheet.less
File lib/views/stylesheet.less (right):

https://codereview.appspot.com/6733060/diff/5002/lib/views/stylesheet.less#newcode896
lib/views/stylesheet.less:896:
This file has some trailing whitespace.  Please remove it before
landing.

https://codereview.appspot.com/6733060/diff/5002/lib/views/stylesheet.less#newcode930
lib/views/stylesheet.less:930: color: #2D2D2D!important;
This color of gray is used a couple of times.  Perhaps you could define
a variable for it.

https://codereview.appspot.com/6733060/

-- 
https://code.launchpad.net/~tveronezi/juju-gui/filter-buttons/+merge/130832
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~tveronezi/juju-gui/filter-buttons into lp:juju-gui.