yellow team mailing list archive

[Matthew Scott <matthew.scott@xxxxxxxxxxxxx>]

Matthew Scott has proposed merging lp:~makyo/juju-gui/charm-panel-border2 into lp:juju-gui.

Requested reviews:
  Juju GUI Hackers (juju-gui)

For more details, see:
https://code.launchpad.net/~makyo/juju-gui/charm-panel-border2/+merge/134354

Charm panel border improvements

>From Matt C.: Shadow should be darker on darker areas in the panel (such as the charm name and search result headings), and the border should extend all the way down to the bottom of the view (was 1px short).

https://codereview.appspot.com/6855049/

-- 
https://code.launchpad.net/~makyo/juju-gui/charm-panel-border2/+merge/134354
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~makyo/juju-gui/charm-panel-border2 into lp:juju-gui.

=== modified file 'app/views/charm-panel.js'
--- app/views/charm-panel.js	2012-11-13 15:27:51 +0000
+++ app/views/charm-panel.js	2012-11-14 18:26:24 +0000
@@ -986,7 +986,7 @@
       var headerBox = Y.one('#charm-search-trigger-container'),
           dimensions = utils.getEffectiveViewportSize();
       return { x: headerBox && Math.round(headerBox.getX()),
-               height: dimensions.height + 17 };
+               height: dimensions.height + 18 };
     }
 
     if (Y.Lang.isValue(trigger)) {

=== modified file 'lib/views/stylesheet.less'
--- lib/views/stylesheet.less	2012-11-13 21:51:29 +0000
+++ lib/views/stylesheet.less	2012-11-14 18:26:24 +0000
@@ -1030,7 +1030,7 @@
         overflow-y:auto;
         overflow-x:hidden;
         background-color: #EEEEEE;
-        width: @charm-panel-width - 1px;
+        width: @charm-panel-width;
         float: right;
         .series-charms {
             h3 {
@@ -1039,10 +1039,13 @@
                 text-transform: capitalize;
                 padding-left: @charm-panel-padding-left;
                 background-color: #CBCBCB;
+                border-left: 1px solid #CBCBCB - #333;
                 border-top: 1px solid #989898;
+                width: @charm-panel-width - 1;
             }
             ul {
                 margin-bottom: 0;
+                border-left: 1px solid lightgrey;
             }
             .charm-entry {
                 padding: 11px @charm-panel-padding-left;
@@ -1313,7 +1316,7 @@
   background-repeat: no-repeat;
   background-position: 230px 38px;
   border-top: 2px solid #dd4814;
-  border-left: 1px solid #2f2a27 + #333;
+  border-left: 1px solid #2f2a27 - #333;
   background-color: #2F2A27;
   height: 90px;
   width: @charm-panel-width - @charm-panel-padding-left - 1px;