← Back to team overview

yellow team mailing list archive

Re: Growl-style notifications. (issue 6851058)

 

Thanks, Francesco.
I like it! I have just one really minor comment.

[]s,
Thiago.



https://codereview.appspot.com/6851058/diff/1/app/views/notifications.js
File app/views/notifications.js (right):

https://codereview.appspot.com/6851058/diff/1/app/views/notifications.js#newcode50
app/views/notifications.js:50: if (notifierBox &&
I think will you always have the 'notifier-box' element. It is
hard-coded in index.html. So probably you can remove this check.

https://codereview.appspot.com/6851058/

-- 
https://code.launchpad.net/~frankban/juju-gui/bug-1076404-growl/+merge/134660
Your team Juju GUI Hackers is requested to review the proposed merge of lp:~frankban/juju-gui/bug-1076404-growl into lp:juju-gui.


References