← Back to team overview

yellow team mailing list archive

Add favicon, tweak Makefile (issue 6842072)

 

Reviewers: mp+135045_code.launchpad.net,

Message:
Please take a look.

Description:
Add favicon, tweak Makefile

Added the juju icon as a favicon, and then got lost in Makefile tweaks.
Makefile now does not do unnecessary work, and no longer hides commands
with @ so that we can see when we reintroduce unnecessary work.  Also
switch from a Makefile comment about the node_modules to a message
generated by the Makefile; maybe this should cause the make to fail, so
that we actually force this to be maintained?

https://code.launchpad.net/~gary/juju-gui/favicon/+merge/135045

(do not edit description out of merge proposal)


Please review this at https://codereview.appspot.com/6842072/

Affected files:
   M Makefile
   A [revision details]
   A app/favicon.ico



-- 
https://code.launchpad.net/~gary/juju-gui/favicon/+merge/135045
Your team Juju GUI Hackers is subscribed to branch lp:juju-gui.


References