← Back to team overview

yellow team mailing list archive

Re: Add favicon, tweak Makefile (issue 6842072)

 

Thanks Gary!
Seems good to me.

+1


https://codereview.appspot.com/6842072/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/6842072/diff/1/Makefile#newcode27
Makefile:27: test -d "$(BUILD_ASSETS_DIR)/stylesheets" || mkdir -p
"$(BUILD_ASSETS_DIR)/stylesheets"
Whats wrong with the use of "@"? Don't we like it any more? :O)

https://codereview.appspot.com/6842072/diff/1/Makefile#newcode42
Makefile:42: @# Check to see if we made what we expected to make, and
warn if we did not.
Do we need this @ before the comment?

https://codereview.appspot.com/6842072/

-- 
https://code.launchpad.net/~gary/juju-gui/favicon/+merge/135045
Your team Juju GUI Hackers is subscribed to branch lp:juju-gui.


References