zim-wiki team mailing list archive

[Dimitrij Lisov <dmt.lsv@xxxxxxxxx>]

Dear Murat,

sorry for my small delay:

1. Could you clarify the separation of those two plugins with Jaap, since
it's not clear when those plugins will officially be part of Zim?

5. Here
<https://mega.nz/#!X9A3RBKK!u3V7yZ_6h4m5HVLRYQ9EIqy6MrolXvDigPYSjgFBnVw>
you can find my autocompletion.py. I think, that I took it from the plugin's
page
<https://github.com/jaap-karssenberg/zim-wiki/wiki/Autocompletion-Plugin>,
while it was there. The only modification I made was changing the "Alt-R +
q" and "Alt-L + q" behavior respectively, like described here
<https://bugs.launchpad.net/zim/+bug/1322201/comments/11>. Please be aware,
that with the latest 0.65-SNAPSHOT-r842~ubuntu16.10.1 this plugin isn't
working anymore. The following error message appears:

This is zim 0.65
Platform: posix
Locale: de_AT UTF-8
FS encoding: UTF-8
Python: (2, 7, 12, 'final', 0)
Gtk: (2, 24, 30)
Pygtk: (2, 24, 0)
No bzr version-info found

======= Traceback =======
  File "/usr/lib/python2.7/dist-packages/zim/actions.py", line 149, in
do_activate
    self.__get__(instance, instance.__class__)()
  File "/usr/lib/python2.7/dist-packages/zim/actions.py", line 132, in func
    self.func(instance, *args, **kwargs)
  File "/home/sojusnik/.local/share/zim/plugins/autocompletion.py", line
106, in auto_completion
    self.set_tag_liststore(zim_index, tag_liststore, entry_completion)
  File "/home/sojusnik/.local/share/zim/plugins/autocompletion.py", line
142, in set_tag_liststore
    self.zim_tags = zim_index.list_all_tags()
AttributeError: 'Index' object has no attribute 'list_all_tags'

6. No examples of other apps come into my mind right now. What about
autocompleting with only one "tab" press, like it's done now with "enter",
instead of two times? If "tab" stays, then its behavior should be the same
as "enter" for autocompleting. But I think, that "enter" (= autocompleting
WITHOUT space after a tag) and "space" (= autocompletion WITH space after a
tag) are already enough for autocompleting. "Tab" should really be used for
cycling through the entries and not autocompleting them, imho.

7. I see, thanks.

8 + 9: The current version
<https://github.com/jaap-karssenberg/zim-wiki/wiki/Tasklist-plugin-with-tag-autocompletion>
of the Tasklist plugin isn't working with the latest
0.65-SNAPSHOT-r842~ubuntu16.10.1 of Zim, so I can't test them.

Many thanks and best wishes!

D


Murat Güven <muratg@xxxxxxxxx> schrieb am Di., 28. März 2017 um 13:11 Uhr:

> Hi Dimitrij,
>
> 1. Yes, I do see your point. I also think that the Tag autocompletion is
> not directly related to the task list. I think it's a matter of if, how and
> when the plugins become official part of ZimWiki.
> Jaap asked me to combine these together to the task list plugin. I think
> it's easier for him to managed them.
>
> 2. []
>
> 3. You are welcome, and thank you for your feedback my (virtual) friend :)
>
> 4. It's a pitty that I can't find the reason why the preferred key binding
> is not working. If anyone has an idea why?
>
> 5. Could it be that I implemented this just for you? Unfortunately I can't
> find this implementation. Could you send the autocompletion.py file to me
> so I can review it please?
>
> 6. I reviewed other autocompletion implementations (e.g. Workflowy or
> Visual Studio). Both do not support cycling through the list with the tab
> key. Do you have another example where it does?
>
> 7. Yes, the bullet in front of the comment does not look right. But with
> the comment line being a bullet, it's easier to parse for a comment. I
> tried to change the parsing but came to the conclusion that it's better to
> have > or >> as a new bullet format (as you describe in 10.) I will look
> into it if I can do this. But this will be a change within the pageview /
> widget / format modules. Therefore the task list plugin / comment plugin
> would not run properly without the modified modules.
>
> 8. I added a selection for the formatting to the preferences. Please see
> attached and let me know what you think.
>
> 9. I added some extra options into the preferences so you can strip down
> the comment string just to ">" if you prefer. Please have a look. This
> might give some weird results for standalone bullet text starting with ">",
> but shouldn't be an issue. Background: I'm looking for the comment string
> to identify a comment.
>
> 10. See 9. I will also have a look for the "quote" or "comment" format,
> but no promises
>
> Thank you and Regards,
> Murat
>
>
>
> On 24.03.2017 20:42, Dimitrij Lisov wrote:
>
> Dear Murat,
>
> 1. I see, that your described way is working too. From a user experience
> point of view I nevertheless propose to separate those plugins, since it's
> not obvious for a new Zim user, that such an useful feature, read
> autocompletion of tags, even exists as a plugin, if it will be remain
> "hidden" in the tasklist plugin. I'm convinced, that there are a lot of Zim
> users, who are using tags, but not the tasklist plugin. They certainly
> won't discover the autocompletion plugin, when it won't be listed in the
> "official" Zim plugins list
> <https://github.com/jaap-karssenberg/zim-wiki/wiki/Plugins> as a separate
> plugin. Do you understand my apprehension?
> Additionally, with a separate plugin, the plugin's options would also be
> decluttered.
>
> 2. That's a pity, but thanks for trying! Maybe another one can contribute
> on that?
>
> 3. It works great in the new version, thanks for that my (virtual) friend!
>
> 4. Yes, I have changed the key-bindings, see
> https://bugs.launchpad.net/zim/+bug/1322201/comments/11. When I reverse
> the change to the default state, I'm able to type an @ in the search field
> again.
>
> 5. In the new version of your tasklist plugin, autocompleting with "space"
> isn't possible anymore. Please restore the old behavior, like it was
> possible in the latest autocompletion plugin. This is for me the most time
> saving feature of your whole plugin :)
>
> 6. I think, that it's already enough to have two ways, with "enter" and
> "space", to autocomple tags. Introducing "tab" could also be useful for
> somebody, who is used to use "tab", but then I propose that "tab" should
> exactly behave like "enter" - it should complete the tag only with one
> press, and not two, like it's implemented now. I personally nearly always
> use "space" for autocompletion, since it completes the tag and also adds a
> space after it, while enter only completes the tag, without a space at the
> end.
>
> I've played around with the updated *tasklist plugin* and have the
> following to share:
>
> 7. From an aesthetical point of view, the bullet point could be removed in
> the comment line. The indent already emphasizes the comment line clearly
> enough, in addition to the comment string itself.
>
> 8. The superscript of the date looks, imho, a little bit out of place,
> because the following comment is written in normal text. Please consider
> adding an option to have the date in normal text.
>
> 9. I also would appreciate an option to entirely remove the date in the
> comment, like you've already implemented with the time. This would again
> declutter the comment line and therefore make it more appealing to the eye.
>
> 10. Is it intended to have an ">" before the comment text, like shown here
> <http://i.imgur.com/LFrTDDm.png>? The comment line would, imho, look much
> cleaner the following way:
> comment (2017.03.24): what if the number of all minds in the universe is
> one?
> or
> comment: what if the number of all minds in the universe is one?
>
> It would be even better, if Zim finally gets an "quote" or "comment"
> format, that normally starts with >, see here
> <https://guides.github.com/features/mastering-markdown/>, to better
> highlight comments. Maybe this could be implemented during Zim's upgrade to
> GTK3 and the like. Maybe Jaap is reading those lines and can give a short
> comment on that.
>
> I'm delighted to see Zim constantly evolving and want to say again a
> warm-hearted "Thank you" to all contributers and of course to Jaap himself!
>
> D
>
> Murat Güven <muratg@xxxxxxxxx> schrieb am Fr., 24. März 2017 um 17:38 Uhr:
>
> Dear Dimitrij,
>
> thank you for your feedback.
>
> 1. Thank you for using the tag autocompletion plugin. I merged this into
> the tasklist plugin, but you won't really see a difference as you can use
> autocompletion without
> starting the tasklist. You just need to activate the tasklist plugin
> within the plugin preferences. Please make sure that the autocompletion
> plugin is deactivated, as
> the same keyboard shortcut is being used. Does this satisfy you?
>
> 2. I reviewed my code and tried to find a way to cycle through the list of
> tags with the tab key, but unfortunately the completion method does not
> support this out of the box.
> There might be a way to handle this, but this is currently out of my
> knowledge. But you can use the tab key instead of the return key as well
> with the new version now.
>
> 3. Yes, this is an excellent idea. I implemented this into the new
> version. I hope it's ok that you can just double click a tag which you want
> to replace ;)
>
> 4. I'm not sure if you have changed the keyboard bindings? I chose ALT + q
> for the plugin activation due to the issues I had with ALT GR + @. Please
> review your bindings and get
> back to me.
>
> Regards,
> Murat
>
>
>
> On 22.03.2017 22:19, Dimitrij Lisov wrote:
>
> Dear Murat,
>
> thank you for your great work!
>
> I have some proposals regarding the tag autocompletion plugin:
>
> 1. Please make it a standalone plugin again. The autocompletion of tags is
> also very useful without the tasklist plugin. I tag a lot of my pages and
> the autocompletion makes this process very convenient. I'm sure, that most
> Zim users share my point of view.
>
> 2. In addition to "arrow up and down" respectively, also "tab" should
> cycle through the suggested tags in the autocompletion pop-up. This just
> feels more intuitive. The "tab" key is also used in other programs to
> complete a suggestion or cycle through them.
>
> 3. When a whole word is marked (f.i. by double-clicking on it) while
> opening the autocompletion pop-up, the selected tag doesn't replace the
> initial marked word, but is placed before the word. It would make more
> sense, when the initial word would be completely replaced by the tag.
>
> 4. Found the following bug: After invoking the search (Ctrl+F) it's not
> possible to write an "@" there, when the autocompletion plugin is enabled.
>
> Wishing you all the best!
>
> Murat Güven <muratg@xxxxxxxxx> schrieb am Di., 21. März 2017 um 13:06 Uhr:
>
> Dear zim community,
>
> please join me in improving the task list plugin. I have implemented some
> additional functionality,
> which you may find useful.
>
> What is new?
>
>    - The comments which are added to a task (via the task comment plugin)
>    are now collected together with the tasks and are displayed in an
>    additional column.
>    - The tags within a task are now displayed in a separate column
>    - You can now tick a task directly within the dialog. As the core task
>    ticking functionality of zim is used for this, zim switches to the page of
>    the task to be ticked.
>    Due to the sorting of the displayed tasks, ticked tasks are sorted at
>    the end of the list before they are removed after index refresh (within
>    seconds)
>    - The dialog is now split into 2 task trees. The second tree displays
>    the history of ticked tasks
>    - When a task is ticked within the dialog, the tick date is stored
>    within the index. This tick date is also displayed within the task history
>    tree.
>    In addition, I updated the pageview module. With this update the tick
>    date is added / removed directly to / from the task within your note.
>    This date is also collected from the task list plugin and is displayed
>    within the task history tree.
>    - The print functionality now displays the open tasks with more
>    information as well.
>
> I also included / updated following plugins into the task list plugin:
>
>    - Tag auto completion (Shortcut: ALT + q)
>    --> Supports you in adding tags by suggesting existing tags
>    --> Removed unwanted frame around the tag entry (within Windows)
>    - Task due date (Shortcut: ALT + period)
>    --> Supports you in adding a due date to a tag (either plain within
>    the text, or with additional entries or as a calendar)
>    - Task comment (Shortcut: CTRL + SHIFT + >)
>    --> The task can now be commented (together with the date / time of
>    the comment)
>    --> The task comments string is added in superstring format, so it
>    does not stand out so much
>
> You should deactive / delete the separate plugins if you already use them.
> I will maintain them only within the task list plugin.
>
> *Direct links:*
> https://launchpadlibrarian.net/311490871/pageview.py
>
> https://launchpadlibrarian.net/311658520/tasklist.py
>
> *Link to the online plugins:*
>
>
> https://github.com/jaap-karssenberg/zim-wiki/wiki/Tasklist-plugin-with-tag-autocompletion
>
> Feedback welcome!
>
> Regards,
> Murat
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~zim-wiki
> Post to     : zim-wiki@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~zim-wiki
> More help   : https://help.launchpad.net/ListHelp
>
>
>
>