brewtarget-devs team mailing list archive

[Philip Lee <rocketman768@xxxxxxxxx>]

Ok, strange. It looks like this might be fixed in the current build. Link
below is a Windows build of the current master branch (487557) with Qt
5.3.2 in Release configuration. Please run and test to verify.

I was able to consistently reproduce the issue with 2.1.0 (temp database
was never deleted). However, with the current build, everything behaves as
expected, with the proper cleanup happening on each run. I looked at the
'git blame' for the database.cpp file, and nothing has really changed since
2.1.0 with respect to the cleanup. The only thing different is my
toolchain. Perhaps this was a bug with Qt 4?

https://dl.dropboxusercontent.com/u/18327217/brewtarget_2.2.0_AMD64.exe

On Sun, Dec 28, 2014 at 8:18 AM, mik firestone <mikfire@xxxxxxxxx> wrote:

> Restore and there was no error message. That's how I realized that I was
> getting different behavior; I added some debug code, compiled and couldn't
> recreate the problem.
>
> Mik
> On Dec 28, 2014 7:33 AM, "Philip Lee" <rocketman768@xxxxxxxxx> wrote:
>
>> Mik,
>>
>> After getting the restore/rollback prompt, which button did you press,
>> and did you get an error dialog afterwards?
>>
>> On Fri, Dec 19, 2014 at 9:33 PM, mik firestone <mikfire@xxxxxxxxx> wrote:
>>
>>> That was my guess as well -- I remember that bit of the code. If I could
>>> do a test build, I would simply put that code back in and see what happens.
>>> I just can't unless there is some way (maybe qt5?) that I can do release
>>> builds with the open source tools I have.
>>>
>>> Thanks for looking into it, though.
>>>
>>> Mik
>>>
>>> On Fri, Dec 19, 2014 at 9:40 PM, Philip Lee <rocketman768@xxxxxxxxx>
>>> wrote:
>>>
>>>> This bug is infuriating. When the backup database deletion code first
>>>> went in, it didn't work at all on Windows. I couldn't get the Qt file
>>>> deletion function to work, and just punted and used a Windows API call.
>>>> This should be the prime suspect. I'll investigate next week after the
>>>> holidays.
>>>>
>>>> On Thu, Dec 18, 2014 at 7:49 AM, mik firestone <mikfire@xxxxxxxxx>
>>>> wrote:
>>>>
>>>>> I don't know if anybody else is tracking this, but we seem to be
>>>>> having a problem deleting the temp db on Windows. Once it is created, it
>>>>> never gets deleted and we are always prompting to restore or rollback.
>>>>>
>>>>> I've tested this myself and can reproduce it, but only when I install
>>>>> brewtarget. If I run brewtarget from my build directory, for example, I
>>>>> never see the problem. I have tried installing brewtarget somewhere other
>>>>> the c:\program files and a few other variants. None of that seems to make a
>>>>> difference.
>>>>>
>>>>> My problem is that I can't build a release on Windows. I don't have
>>>>> the necessary environments. Can somebody who can build Windows releases
>>>>> take a look into this and see what's going on?
>>>>>
>>>>> Thanks,
>>>>> Mik
>>>>>
>>>>> --
>>>>> In a world of ninja v. pirate, I pilot a Gundam
>>>>>
>>>>> --
>>>>> Mailing list: https://launchpad.net/~brewtarget-devs
>>>>> Post to     : brewtarget-devs@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~brewtarget-devs
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Dr. Philip G. Lee
>>>> www.linkedin.com/in/philipgreggorylee
>>>>
>>>> --
>>>> Mailing list: https://launchpad.net/~brewtarget-devs
>>>> Post to     : brewtarget-devs@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~brewtarget-devs
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>>
>>>
>>>
>>> --
>>> In a world of ninja v. pirate, I pilot a Gundam
>>>
>>
>>
>>
>> --
>> Dr. Philip G. Lee
>> www.linkedin.com/in/philipgreggorylee
>>
>


-- 
Dr. Philip G. Lee
www.linkedin.com/in/philipgreggorylee