| Thread Previous • Date Previous • Date Next • Thread Next |
On Sun, 13 Nov 2011, Daniel van Vugt wrote:
Thanks, I'll take a good look another day. Only one question: Is it acceptable to disable the panel blur for people who have non-standard unity plugin settings like me? (panel opacity < 1.0) Given panel opacity is meant to be 1.0, I don't *think* that would be breaking the unity design (?)
I'm not sure, however, blur-behind-panel shouldn't come at much of a performance cost. Remember that the framebuffer object only needs to be bound and updated if a relevant blur region needs to be updated, so if there's no intersection of the damage region in a paint cycle there is no need to bind the fbo.
However, there is a case where the blur will slightly lag behind whatever is being painted because the damage calculation will come at the end of the paint cycle and this will be too late to update the panel blurs until the next paint. In that case, we'll need to use a core change (change in the API) which is only available in the precise version of compiz, which makes CompositeScreen::damageRegion a wrapped function, and in that case, the framebuffer object would need to be bound, and glCopyTexSubImage2D would be used to copy the backbuffer into the framebuffer.
I can ask for design feedback on this, though, on first principles I'd say that blurs should work that either they are on, or they aren't. I know that last cycle we wanted to do blur-behind-launcher all the time too, and we hit this same limitation, to which is largely solved by the solution I described above. However, at the time, compiz was in API freeze.
On 13/11/11 17:45, Sam Spilsbury wrote:On Sun, 13 Nov 2011, Daniel van Vugt wrote:Also, disabling the blur when the dash is not visible would probably solve bug 865006.Thanks Daniel. The BackgroundEffectHelper class has a static list of active blur regions, when that's zero, I'd say just don't bind the framebuffers (but you will need to do glCopyTexSubImage2D into the framebuffer once you enable the framebuffers again to avoid artifacts)-- You received this bug notification because you are a member of compiz packagers, which is subscribed to compiz in Ubuntu. https://bugs.launchpad.net/bugs/861061 Title: Unity makes 3D apps run much slower. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/compiz/+bug/861061/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~compiz Post to : compiz@xxxxxxxxxxxxxxxxxxx Unsubscribe : https://launchpad.net/~compiz More help : https://help.launchpad.net/ListHelp-- You received this bug notification because you are a member of compiz packagers, which is subscribed to compiz in Ubuntu. https://bugs.launchpad.net/bugs/861061 Title: Unity makes 3D apps run much slower. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/compiz/+bug/861061/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~compiz Post to : compiz@xxxxxxxxxxxxxxxxxxx Unsubscribe : https://launchpad.net/~compiz More help : https://help.launchpad.net/ListHelp
| Thread Previous • Date Previous • Date Next • Thread Next |
