← Back to team overview

dhis2-devs team mailing list archive

Re: Greetings + new DHIS patient module

 

On Mon, Mar 1, 2010 at 4:02 PM, Bob Jolliffe <bobjolliffe@xxxxxxxxx> wrote:

> Hi Viet
>
> On 1 March 2010 08:22, Viet Nguyen <phamquocviet@xxxxxxxxx> wrote:
>
>> Hi,
>>
>>
>> On Mon, Mar 1, 2010 at 11:13 AM, Chau Thu Tran <
>> tran.hispvietnam@xxxxxxxxx> wrote:
>>
>>> Hi Abyot and Others,
>>>
>>> I tested the* UpdatePatientAttributeValues *function. It doesn't show
>>> anything. I think if we have *EditPatient*, we don't need *
>>> PatientAttributeValues*.
>>>
>>
>> Yeah, this is a bug, we changed Attribute object so this function should
>> be updated . I will fix that.
>> Let's keep it there for a while, later when everything is fine then we can
>> have a look at all the functions and decide whether to keep it or not.
>>
>>
>>>
>>> *About enter name for Patient and Patient attribute*
>>>       - The validate function ( *required_group {validate...*)  doesn't
>>> allow to enter Vietnamese in Add/Update patient, Add/Update PatientAttribute
>>> ,....
>>> *VD: Châu --> Warning message: Please Letters, numbers, spaces and
>>> underscores only.*
>>>
>>
>> This is just rule of jquery validation, I can remove that .
>>
>
> This exposes quite an interesting problem regarding the use of regex based
> validators - such as the jquery validation plugin.  I see that you made some
> mods to the plugin to allow internationalized messages, nut the bigger
> problem may be with the underlying regexes themselves.  In Jason's broader
> vision of regex use we need to take into account internationalized regexes.
> So for example [a-zA-Z] looks useful but it is of course not universally
> applicable. If we needed to match Gujerati characters we would need
> something like [\u0A80-\u0AFF].
>
> Not wanting to hijack this thread, I think we need to add this
> internationalisation requirement to the regex blueprint and maybe discuss it
> elsewhere.  And meanwhile beware of things like "alphanumeric" in the jquery
> plugin as it clearly seems to make assumptions about character ranges.
>
> Ok, I understand the problem. Will remove the alphanumeric things for now.
I'm not sure how to integrate this client validation with what Jason
did...will try to have a look at that when I have time.

-- 
Viet Nguyen

Follow ups

References