| Thread Previous • Date Previous • Date Next • Thread Next |
Johan Hake wrote:
On Wednesday 01 October 2008 11:48:17 Garth N. Wells wrote:Johan Hake wrote:Hello! Attached is a bundle with changes to the GenericMatrix interface regarding the operators +=, -= and axpy. These operators are also added in PyDOLFIN together with the + and -.Nice. I just pushed the changes to dolfin-dev.Thanks!It would be nice to have some unit tests (not just for this, but for much more and from all of us in general).I agree. Its tedious but very usefull. A more general unit test for the linear algebra should probably include more than the stripped down version I handed,
I didn't notice at first glance that you already added some. Thanks! e.g. actually solving a system,
using _all_ the possible ways we can do that in DOLFIN,
Yes, I ran into a nasty uBLASMatrix bug this week which was only exposed when using the UmfpackLUSolver in a particular way which have been picked up by a unit test.
Garth but I suppose its
better than nothing :) JohanGarthI have implemented all operator= and copy constructors for the included Matrices, excluding STLMatrix. I kept the copy constructor explicit, and therefor I did not implement the the + or - operator. These can be added, but will lead to unnesessary many temporary matrix objects. I have cleaned up in the swig la interface files. I added a unit test for the added operators in Python, for all backends, and a dummy unit test in cpp. We should fill that one out... Now I know alot more about operators, copy constructors and swig interface files, than I did three days ago :) Johan ------------------------------------------------------------------------ _______________________________________________ DOLFIN-dev mailing list DOLFIN-dev@xxxxxxxxxx http://www.fenics.org/mailman/listinfo/dolfin-dev
| Thread Previous • Date Previous • Date Next • Thread Next |
