dolfin team mailing list archive

["Garth N. Wells" <gnw20@xxxxxxxxx>]

On 04/04/11 10:36, Kent-Andre Mardal wrote:
> 
> 
> On 4 April 2011 11:25, Garth N. Wells <gnw20@xxxxxxxxx
> <mailto:gnw20@xxxxxxxxx>> wrote:
> 
> 
> 
>     On 04/04/11 09:49, Kent-Andre Mardal wrote:
>     > I have a unit test that I can include.
>     >
>     > BTW: A couple of issues concerning this patch.
>     >
>     > 1. I have used a std::map for a global -> local mapping. I don't
>     know if
>     > this
>     >     the most efficient thing to do, but it is certainly convenient.
>     >
> 
>     boost::unordered_map is another possibility.
> 
> 
> I need to search through it afterwards so I think it is an advantage if
> it is
> ordered.
>  

You need to test. boost::unorderd_map can be very fast for searches.

Garth

> 
> 
>     > 2. The boundary indicators are read on every process because these
>     >     arrays are small. Their dimensions are the number of cells on the
>     > boundary.
>     >
> 
>     This isn't scalable - we would need an enhanced alternative.
> 
>     Garth
> 
> 
> Sure, but it is still the fastest thing to do when the number of
> processors are small (I think).
> 
> Kent
>  
> 
>     >
>     > On 4 April 2011 10:20, Garth N. Wells <gnw20@xxxxxxxxx
>     <mailto:gnw20@xxxxxxxxx>
>     > <mailto:gnw20@xxxxxxxxx <mailto:gnw20@xxxxxxxxx>>> wrote:
>     >
>     >     I would prefer to not apply this just yet. I'm in the process if
>     >     re-factoring some aspects of parallel mesh functionality. Some
>     classes
>     >     and functions have gotten out of hand.
>     >
>     >     Register a branch and a merge request so that it doesn't get
>     forgotten.
>     >     Unit tests are also required before patches will be applied.
>     >
>     >     Garth
>     >
>     >
>     >
>     >     On 04/04/11 07:52, Kent-Andre Mardal wrote:
>     >     >
>     >     > Please consider the attached patch.
>     >     >
>     >     > Kent
>     >     >
>     >     >
>     >     >
>     >     > _______________________________________________
>     >     > Mailing list: https://launchpad.net/~dolfin
>     <https://launchpad.net/%7Edolfin>
>     >     <https://launchpad.net/%7Edolfin>
>     >     > Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
>     <mailto:dolfin@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:dolfin@xxxxxxxxxxxxxxxxxxx
>     <mailto:dolfin@xxxxxxxxxxxxxxxxxxx>>
>     >     > Unsubscribe : https://launchpad.net/~dolfin
>     <https://launchpad.net/%7Edolfin>
>     >     <https://launchpad.net/%7Edolfin>
>     >     > More help   : https://help.launchpad.net/ListHelp
>     >
>     >     _______________________________________________
>     >     Mailing list: https://launchpad.net/~dolfin
>     <https://launchpad.net/%7Edolfin>
>     >     <https://launchpad.net/%7Edolfin>
>     >     Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
>     <mailto:dolfin@xxxxxxxxxxxxxxxxxxx>
>     >     <mailto:dolfin@xxxxxxxxxxxxxxxxxxx
>     <mailto:dolfin@xxxxxxxxxxxxxxxxxxx>>
>     >     Unsubscribe : https://launchpad.net/~dolfin
>     <https://launchpad.net/%7Edolfin>
>     >     <https://launchpad.net/%7Edolfin>
>     >     More help   : https://help.launchpad.net/ListHelp
>     >
>     >
> 
>