dulwich-users team mailing list archive

[Jelmer Vernooij <jelmer@xxxxxxxxx>]

Hi David,

On Mon, 2011-03-14 at 18:11 -0400, David Blewett wrote:
> On Sun, Mar 13, 2011 at 10:34 PM, Jelmer Vernooij <jelmer@xxxxxxxxx> wrote:
> > I had contrib/ in mind rather than dulwich/contrib, so that the paster
> > app doesn't get installed, as is it is untested. The setup.py change
> > also breaks compatibility with distutils.
> 
> The problem with having it in the top-level dir instead of inside
> dulwich/ is that Paster won't then be able to find where the dir is.
> The entry points have to point to a known location in the PYTHONPATH.
> As for the distutils compatibility, I had missed the fallback import.
> I can re-structure setup.py to not pass the kwarg when using
> distutils; Paste.Deploy requires setuptools (again, because the
> entry_points functionality).
Ideally we'd only specify it if setuptools is used, though looking
closer I see that distutils just gives a warning if it is specified, it
doesn't break completely. So I guess that's not as big of an issue as I
initially thought.

> > Alternatively, perhaps we should look at making it dulwich.paster (or
> > dulwich.web.paster ? ) but also adding some unit tests, etc and keeping
> > setuptools optional.
> 
> I don't particularly care where it lives, as long as it's somewhere
> under dulwich/ . I can add some tests for the option parsing
> functionality in the app factory; are tests required for the filter
> factories? They basically just make Paster aware of their existence;
> there are no options for them currently.
As discussed on IRC, I'd be more than happy to have it live in
dulwich.paster or dulwich.web.paster (perhaps the latter is more appropriate), if
you can add some basic tests. My main concern is keeping this code up
to date while the rest of Dulwich evolves. 

We've had code in the tree that wasn't tested (or used very often) and
therefore broken by API changes we made. I'd like to prevent that from
happening again.

> > Can you add a license/copyright header to paster.py ?
> 
> Will do; once I've heard back about a final home for these, I'll
> submit a new patch and push to my github fork.
Looking forward to it.

Cheers,

Jelmer

Attachment: signature.asc
Description: This is a digitally signed message part