hipl-core team mailing list archive

[Diego Biurrun <diego@xxxxxxxxxx>]

On Sun, Aug 29, 2010 at 06:42:42PM +0200, Christof Mroz wrote:
> On Sun, 29 Aug 2010 17:50:12 +0200, Diego Biurrun <diego@xxxxxxxxxx> wrote:
>
>> Maybe the following part of the HACKING document is in need of  
>> rephrasing:
>>
>>   Long lines (>80 characters) should be broken at suitable places
>>   where doing so improves readability.
>>
>> --->
>>
>>   Long lines (>80 characters) should be broken at suitable places
>>   if and only if doing so improves readability.
>>
>> Is the latter clearer?
>
> Hum... so reformatting this (A)
>
>             ctx->transport_hdr.tcp = (struct tcphdr*)
>                     (((char *) ip6_hdr) + sizeof(struct ip6_hdr));
>
> to this (B)
>
>             ctx->transport_hdr.tcp = (struct tcphdr*)
>                                      (((char *) ip6_hdr) + sizeof(struct ip6_hdr));
>
> rather than this (C)
>
>             ctx->transport_hdr.tcp = (struct tcphdr*)
>                                      (((char *) ip6_hdr) +
>                                       sizeof(struct ip6_hdr));
>
> is recommended even though in (B) the second line is slightly longer than 
> 80 characters (and (A) still looks readable, imho) while in (C) it is  
> within the threshold?

Both (B) and (C) are more readable than (A).  Choose your poison.

Diego