← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] non-interactive plot mode for eeschema


On Friday 15 May 2009, Dick Hollenbeck wrote:
> The C++ style is wrong.

In defense of Dick, and to explain it to Werner ...

I'm assuming you mean things like curly brace placement and 
other things that are a matter of opinion.

There are many styles that are equally valid. I have my 
preference, but have no problem with others who may prefer 


Within a body of code, it is important to be consistent. If you 
mix styles within a body of code, it looks like crap and 
eventually becomes totally chaotic.

Therefore, it is the duty of anyone who contributes to an 
existing body of code to learn the style that is in place, and 
do it that way, even if you prefer something different.

> This should not be committed in my opinion.
> I think this is a patch that you can maintain Werner for your
> personal needs.

I think Kicad needs to consider implementing a plugin system, 
similar to what is in Gnucap.

The idea is that there is a minimal stable core that is 
maintained strictly, and whatever possible is moved out to 
plugins. It is based on standard shared-object modules and C++ 
derived classes.

Then, anyone can share anything as a plugin, without impacting 
the main program for those who don't want to use it.

If there is interest, I will gladly explain how it works and 
provide guidance to implement it.


Follow ups