kicad-developers team mailing list archive

Thread
Date

rev 3419

To: KiCad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx>
From: Dick Hollenbeck <dick@xxxxxxxxxxx>
Date: Sat, 18 Feb 2012 22:21:50 -0600
Authentication-results: mr.google.com; spf=pass (google.com: domain of dick@xxxxxxxxxxx designates 10.182.31.47 as permitted sender) smtp.mail=dick@xxxxxxxxxxx; dkim=pass header.i=dick@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.27) Gecko/20120216 Thunderbird/3.1.19

It is beyond ridiculous, but commit/patch in version 3419 contains a diff of 10385 lines. 
(A personal record, not one I am proud of.)

It is a furtherance of our efforts of making KiCad into a C++ program.  This one
encapsulates class D_PAD (which is quite an important class, used in a lot of places). 
There was little hope in doing this piecemeal.

I estimate that the possibility of this one introducing bugs at about 25%.

Please exercise empathy when or if you get burned from my 2 weeks of work.

It is a pleasure being able to contribute to KiCad.

Dick


P.S.  Jean-Pierre, please grep for "@JP" and remove those comments after you answer the
questions (fix the code) in those locations.

Follow ups

Re: rev 3419
From: Miguel Angel Ajo Pelayo, 2012-02-19