← Back to team overview

kicad-developers team mailing list archive

Re: Why ALL capital letters for classes and typedefs


Hi guys, I think this is nothing to be changed right now.

Those are the kind of changes that can be made to a project just in certain
(like the time when there are no branches from main sources -and we have
mine included-).

If you start changing capitalization on all files around you'll get DVCS
branches broken,
and it will lead to a lot of "useless" work, a work that will give very
little gain.

I agree that the current standard could lead to little confusion sometimes,
but it's not bad at
all, it gives uniformity to our source code, and it's more than enough.

My 2 cents.

2012/6/23 Dick Hollenbeck <dick@xxxxxxxxxxx>

> On 06/22/2012 05:55 PM, Alexander Lunev wrote:
> > I believe most developers agree to follow some project predetermined
> coding style policy...
> >
> > According to the KiCad coding style policy, constants and macro names
> should be
> > comprised of all capital letters (it is common, that is OK). However,
> according to the
> > policy, classes and typedefs should be designated in the same way (all
> capital letters).
> > So it is easier to get confused while reading the source code,
> especially for developers
> > who get used to names written in all capital letters and implied as
> either constants or
> > macros.
> >
> > As for me, wxSomeClass and kiSomeClass names are quite good ones. I
> think these examples
> > are still in conformance with the common convention. wx and ki are just
> prefixes to
> > highlight a subset of classes.
> The kicad coding standards clearly state the classnames are to be
> uppercase.
> I am quite certain that Wayne will go ballistic if this stops being
> enforced.
> Get over it.  That decision has been made, and I personally spent about
> $30,000 of my time
> getting the code base this way.
> In total there has probably been $70,000 spent on it, and about 45% of
> that is from Wayne.
> So do you think you have a chance at making this case name argument?  Not
> on this planet,
> not in this project.
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


Miguel Angel Ajo Pelayo
+34 636 52 25 69
skype: ajoajoajo

Follow ups