kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #08488
Re: Why ALL capital letters for classes and typedefs
On Sat, Jun 23, 2012 at 01:38:21PM -0400, Wayne Stambaugh wrote:
> I don't know if I would go ballistic but I do know one thing I would
> not do and that is convert code as it stands now to another coding
> standard after all the time and effort I spent getting the original
> code into the current format. The KiCad coding standards were
I personally wouldn't have touched the original code... usually we (at work) we
set a standard from that point on. Unless there is a complete code freeze that
would create unnecessary diffs which would be *extremely* inconvenient for
other developers (especially branchers).
> stated in the coding policy, the only thing worse than looking at
> code formatted in a style that you don't like is looking at 10
> different formats that you don't like in the same source file. I
> think we can all agree on that. The most important reason to follow
I actually I'm being used to read code written and patched in decades by
different teams (with questions like: "why all the labels are 6 characters
long?" "because one of the previous developers was used to *another system*
which had that limitation). Given that I'm in system integration/adaptation
maybe that's uncommon for other developers:P
> coding standards is in order to show respect of the work done by
> everyone who came before you. If you can understand this, then
> understanding the consistency part is mute. I hate the GNU coding
No issue for me; as I said just tell how you need it done:D the *really* fun
standards are these like MISRA C with rules like (more or less) "you can't use
pointers". Good luck with them!
> I would like to propose an experiment. Join the Linux kernel
> mailing list and publicly scold Linus about how much you don't like
> Linux kernel coding style. Then sit back and wait for a response.
Naah I don't think its that so anymore. I was referring *exactly* to Torvalds
when I talked about dictatorships... (he seems to also hate GNU coding
standards, like many others... From CodingStyle)
"First off, I'd suggest printing out a copy of the GNU coding standards,
and NOT read it. Burn them, it's a great symbolic gesture"
Given that premise the outcome of the experiment would be clear (but he also
says that standards are not exactly mandatory, but must be taken in
consideration)
--
Lorenzo Marcantonio
Logos Srl
References