kicad-developers team mailing list archive

[Dick Hollenbeck <dick@xxxxxxxxxxx>]

Wow.  There's a man with a positive attitude, that is why we want him on
our team.
On Mar 15, 2013 9:23 AM, "Miguel Angel Ajo Pelayo" <miguelangel@xxxxxxx>
wrote:

> You're right dick, I promise you that I was at this task before reading
> your email,
> I re-read te kicad coding style policy last night, and now I can see many
> mistakes.
>
> I'm cleaning the code and fixing a couple of assert errors from wx in
> debug mode (never
> used it on debug mode until now, and when I enter my interfaces asserts
> start popping…)
>
> So, my next commit goes with style cleanups and ex-related-cleanups.
>
> Thanks for telling me nicely, coding style is important and it seems that
> I haven't been
> paying enough attention.
>
> Miguel Angel Ajo
> http://www.nbee.es
> +34911407752
> skype: ajoajoajo
>
> On 15/03/2013, at 14:43, Dick Hollenbeck <dick@xxxxxxxxxxx> wrote:
>
> > On 03/15/2013 07:58 AM, Miguel Angel Ajo Pelayo wrote:
> >> I think I will fix it back to   value.Replace(wxT( "," ),wxT( "." ));,
> which seems to work
> >> with wxwidgets 2.8 (was the wxT(..) missing what broke it)
> >>
> >> And It's the internal implementation of wxwidgets wxString CDouble
> things .
> >
> > Miguel,
> >
> > Minor change of topic....
> >
> > That file in general, looks terribly incompatible with the coding
> > standards, please fix it while you are in there:
> >
> > a) trailing whitespace needs to be removed, even from blank lines.
> > b) no space after if.
> > c) blank line after if group.
> > d) line 183 on two lines
> > e) move the function comments into the header file and out of the
> > *.cpp file.
> > f) no blank line before closing }
> >
> > e.g.
> >
> >    DisplayWizardInfos();
> >
> > }
> >
> >
> >
> > I look at your code and I can tell who wrote it.  In this case, that
> > is a problem IMO.
> >
> >
> > Thank you.
> >
> > Dick
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
>