kicad-developers team mailing list archive

[Tuomas <tuomasvaherkoski@xxxxxxxxx>]

Hello,
so I have made some changes:

I extracted old vrml parsing functions from S3D_MASTER and created a
VRML_MODEL_PARSER
class from them.
I added an factory method to abstract S3D_MODEL_PARSER class which can
construct the correct parser based on file extension.
The code now supports vrml exporting when board contains x3d models.
X3D_MODEL_PARSER now also supports rotation property in the transform nodes.

What do you think? Diff against r4022
Thanks

- Tuomas



On Wed, Mar 20, 2013 at 1:23 AM, Miguel Angel Ajo Pelayo <
miguelangel@xxxxxxx> wrote:

> The patch doesn't look bad to me, well written, and seems to comply
> (visual check) with the coding standards.
>
> Still untested, I could test and commit, I see nothing bad, If it becomes
> a maintenance problem in the future,
> and we don't use it we could simple drop it, but if it's useful, I'm sure
> we will take care to maintain it.
>
> What do others think?
>
> Tuomas, thanks a lot for taking care of code standards and submitting.
>
>
> Miguel Angel Ajo
> http://www.nbee.es
> +34911407752
> skype: ajoajoajo
>
> On 19/03/2013, at 23:20, Cirilo Bernardo <cirilo_bernardo@xxxxxxxxx>
> wrote:
>
> >> ________________________________
> >> From: Tuomas <tuomasvaherkoski@xxxxxxxxx>
> >> To: kicad-developers@xxxxxxxxxxxxxxxxxxx
> >> Sent: Wednesday, March 20, 2013 4:25 AM
> >> Subject: [Kicad-developers] [PATCH] Implementing X3D model support to
> 3d-viewer
> >>
> >>
> >> Hello everyone,
> >>
> >>
> >> I've been writing some code to implement X3D support to
> 3d-viewer/pcbnew so that it would be easier to use other software than just
> Wings3D to export 3d-models. The basic functionality is implemented and it
> seems to work fine. There is still some things to be done, like supporting
> Transform rotation property.
> >> I just wanted to post this patch to get some feedback.
> >>
> >>
> >> The parser is implemented in its own class which fills the required
> fields of S3D_MASTER class.
> >> I was thinking that I could also move the current wrl parser into its
> own class.
> >>
> >>
> >>
> >> I also made changes to dialog_edit_module_for_Modedit.cpp so that it
> now supports loading of *.x3d files.
> >>
> >>
> >> Please let me know what you think. The source is branched from r4017.
> >> Thanks.
> >> - Tuomas Vaherkoski​
> >>
> >>
> >
> >
> > On the practical side I really don't think we need yet another format
> for 3D views. Wings3D is so awful that I created my own tools for
> developing 3D VRML models, but although I can understand the frustration I
> think effort is better directed to supporting the existing 3D viewer
> functionality and in the future supporting tools to create solid models and
> STEP output.
> >
> > On the other hand, if there are good vrml->X3D converters and we can
> make use of the existing VRML models, I see nothing wrong with replacing
> the 3D viewer and 3D exporter with new ones. Better still if the 3D viewer
> can take both X3D and VRML models - the only thing to keep in mind is that
> people currently use the VRML export as part of their process to create
> STEP files, so if the exporter is replaced there needs to be a tested
> method for creating STEP files.
> >
> > - Cirilo
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
>


-- 
Ystävällisin terveisin
Tuomas Vaherkoski
0408473986

Attachment: x3d_file_support_v2.patch
Description: Binary data