kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxxxx>]

On 11/14/2013 4:22 AM, Константин Барановский wrote:
>> Thanks, but where is the patch? (there is no attachment).
> 
> Sorry, my fault :)
> I'm started to write the message at home but finished at work and forgot
> to attach the patch.

The patch looks good to me.  I've attached a screen shot of the bounding
box with text rotated 135° and it looks about right.  If there are no
objections, I will commit the patch.  It does point out a glaring
weakness in our current bounding box limitations.  There is definitely
an opportunity to significantly improve hit testing by moving to the
boost geometry library to handle our geometric objects.

> 
> Regards,
> Konstantin.
> 
> 
> 2013/11/14 jp charras <jp.charras@xxxxxxxxxx <mailto:jp.charras@xxxxxxxxxx>>
> 
>     Le 14/11/2013 07:17, Константин Барановский a écrit :
>     > Wayne,
>     > RotatePoint must be called twice. I'm added the comments to explain
>     > why need both calls.
>     >
>     > jp charras,
>     > I checked the display of text in PCBnew where to use multiline text
>     > inside the zone.
>     >
>     > In attachment the edited patch where added comments and some
>     optimization.
>     >
>     > Regards,
>     >
>     > Konstantin.
>     >
> 
>     Thanks, but where is the patch? (there is no attachment).
> 
>     Multiline texts in zones do not uses exactly the bounding box.
>     The bounding box is always an horizontal rectangle, which is not the
>     case in zones (try a 45 deg multiline text)
> 
>     To show the bounding box, see TEXTE_PCB::Draw in class_pcb_text.cpp,
>     line 110
> 
>     --
>     Jean-Pierre CHARRAS
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Attachment: justify_patch_bbox.png
Description: PNG image