kicad-developers team mailing list archive

[Adam Wolf <adamwolf@xxxxxxxxxxxxxxxxxxxx>]

There is a script in the source tree that does something like this.  I
think Dick wrote it.

Adam Wolf
W&L


On Tue, Feb 4, 2014 at 4:02 PM, Maciej Sumiński <maciej.suminski@xxxxxxx>wrote:

> I guess you could run uncrustify and do a diff, but unfortunately you
> cannot apply uncrustify blindly - sometimes its output seems a bit odd. One
> possible solution is to check how many lines were corrected by uncrustify,
> if above a set threshold (relatively to the whole patch length) - send an
> e-mail to the commiter containing formatting hints.
>
> Regards,
> Orson
>
>
> On 02/04/2014 10:00 PM, Miguel Angel wrote:
>
>> Hmmm,
>>
>> Do we have something to check coding style compliance?
>>
>> Not sure if uncrustify does code checking along with reformating.... if
>> we had that
>> we could automatically check submitted code for style compliance.
>>
>>
>>
>> ---
>> irc: ajo / mangelajo
>> Miguel Angel Ajo Pelayo
>> +34 636 52 25 69
>> skype: ajoajoajo
>>
>>
>> 2014-02-04 Miguel Angel <miguelangel@xxxxxx <mailto:miguelangel@xxxxxx>>:
>>
>>
>>
>>     Hi!, thanks for the enthusiasm! :)
>>
>>     2014-02-04 Fabrizio Tappero <fabrizio.tappero@xxxxxxxxx
>>     <mailto:fabrizio.tappero@xxxxxxxxx>>:
>>
>>
>>         I completely agree. Jenkins for Kicad is going to be a blast!! I
>>         hope i could help in some how in the future.
>>         Mui bien echo macho !
>>         Fab.
>>
>>         On 03/02/2014 10:44 PM, "inkblotter" <inkbottle@xxxxxxxxx
>>         <mailto:inkbottle@xxxxxxxxx>> wrote:
>>
>>             On 02/02/2014 04:12 PM, Miguel Angel wrote:
>>
>>>             [....]
>>>
>>             Miguel,
>>
>>             Let me applaud and encourage you in tackling this important
>>             step forward for Kicad, of automated Jenkins builds of the
>>             Kicad source and automated tests.   I have worked with
>>             Jenkins doing automated builds and tests on multiple
>>             platforms in the past, albeit only with Java.  I'm impressed
>>             that you are extending it to do C++ builds and tests, with
>>             the help of Python
>>
>>
>>     Jenkins is so modular that can be used for many automated works. I
>>     used to work with something similar (bamboo), but that's commercial
>>     software, it's good, but even if they give you a
>>     license for free, you have to keep fighting and asking for license
>>     renewals to stay updated, and ... I'm sorry, but they can't bet an
>>     "rpm update, or apt-get update, etc..."
>>
>>             I do believe that any automated build and test mechanism
>>             should run on all supported platforms, both 32-bit and 64-bit.
>>
>>
>>     It's a good point, yes, it requires more resources, but it's
>>     probably something interesting to do.
>>
>>     We could probably throw in a 32bit slave + win32 + win64 slaves if
>>     we have CPU, ram enough and licenses.
>>     Or we can ask for volunteers here, I know that is on Adam wolf's
>>     plans, at least for MacOSX, but I believe
>>     he was thinking of doing the same for Windows.
>>
>>
>>             I can't help you in the effort other than peripherally since
>>             I have other Kicad-related itches  that will consume most of
>>             my available time in the next month or two. This is a huge
>>             task; you can't do automated testing all by yourself
>>             effectively.  Eventually, other developers would have to
>>             contribute over time.   I think this is an important step
>>             forward in any mature and stable code base. Fortunately,
>>             after the mechanism is flushed out, this can be done and
>>             enhanced incrementally over time.
>>
>>
>>     Yes, I'm just laying down the road, but for this to work, eventually
>>     we will need tests developed along with new code. That doesn't come
>>     for free, but it pays for itself on the longterm (for example,
>>     somebody new can come, patch something or add a feature... without
>>     the test he doesn't realize that he's breaking a few other things...
>>     but with the test he knows.. and he can do the right thing: either
>>     fix the test, or fix his new code.)
>>
>>
>>             Again, thanks for your efforts on behalf of Kicad.
>>
>>
>>     I'm happy to help. It's a project I like, and it's a project which I
>>     find very important for the future of
>>     anything related to electronics, computing, etc... without a decent
>>     free/open electronic CAD there
>>     will be no open hardware...
>>
>>
>>     Cheers,
>>     Miguel Ángel Ajo,
>>
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>