kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 16/02/2014 19:06, Dick Hollenbeck a écrit :

<...>

> 
> Thank you.  I can see now.
> 
> Genearally, we should supply COMPILING_DLL, when:
> 
> a) including import_export.h, and
> 
> b) either compiling a DLL, or implementing a function that would otherwise be exported.
> (In any case, *not importing*.  And you don't import something you are implementing.)
> 
> 
> Here there is not actually a need to export, but for source compatibility there is no
> harm.  On ELF binaries you'll see just that one symbol, because most all the rest are hidden.
> 
> 
> I think the bug was line 18 of bitmap2component/CMakeLists.txt.  That region should look
> like this:
> 
> 
> set_source_files_properties( ../common/single_top.cpp PROPERTIES
>     COMPILE_DEFINITIONS     "TOP_FRAME=0"
>     )
> set_source_files_properties( bitmap2cmp_gui.cpp PROPERTIES
>     COMPILE_DEFINITIONS     "COMPILING_DLL"
>     )
> 
> 
> For single_top: that removes the BUILD_KIWAY_DLL and adds the COMPILING_DLL to the
> compiler command line.
> 
> For bitmap2cmp_gui.cpp, that adds the COMPILING_DLL.
> 
> The import export thing was not detectable on linux since APIEXPORT and APIIMPORT are the
> same.
> 
> 
> Thanks for YOUR help.  Please try revision 4664 which is hopeful for working.
> 
> This gives us a platform for moving forward into the other programs.  The first ones are
> always hardest.  :)
> 
> 
> Dick

Dick,

Great success:
All issues I found are now fixed, both on Linux and on Windows/mingw.

Thank you.


-- 
Jean-Pierre CHARRAS