kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxxxx>]

On 9/26/2014 8:28 PM, Cirilo Bernardo wrote:
>> ________________________________
>> From: Blair Bonnett <blair.bonnett@xxxxxxxxx>
>> To: Wayne Stambaugh <stambaughw@xxxxxxxxxxx> 
>> Cc: KiCad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx> 
>> Sent: Saturday, September 27, 2014 8:19 AM
>> Subject: Re: [Kicad-developers] Build changes.
>>
>>
>>
>> Hi Wayne,
>>
>>
>>
>> I just committed revision r5149 which fails when wxWidgets is less than
>>> version 3.0.0.  I know that the wx3 is not without it's issues but it is
>>> becoming too much of a burden to try to keep the code compatible with
>>> wx2 along the known issues.
>>>
>>
>>
>> The updated FindPackageHandleStandardArgs.cmake does not work on my system (up-to-date Arch Linux). On lines 130 and 131 we have
>>
>>    include(${CMAKE_CURRENT_LIST_DIR}/FindPackageMessage.cmake)
>>    include(${CMAKE_CURRENT_LIST_DIR}/CMakeParseArguments.cmake)
>>
>> which look in the KiCad CMakeModules/ directory for those two files. Since they don't exist, CMake quits with an error. Replacing those lines with the old
>>
>>
>>    include(FindPackageMessage)
>>    include(CMakeParseArguments)
>>
>>
>> finds the files that ship with CMake and the build proceeds. I'm not sure whether you intended to put a copy of these files in the CMakeModules directory or what.
>>
>>
> 
> 
> In addition to those files not being in the source directory, it
> seems that some macros are used which are specific to CMake >= 3.0.
> If that's the case then we also need to change the specified
> minimum CMake version in the top level file.
> 
> - Cirilo 
> 

Thanks.  I just discovered that myself.  I'll have to pull in the
additional cmake files from 3.0.  I don't want to bump the CMake version
to 3.0 yet.  CMake 3 hasn't been out that long.  The other option is to
just remove FindPackageHandleStandardArgs.cmake and use the one that
ships with CMake.  I don't think there was anything custom in the
version I replaced.