kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #16197
Re: [PATCH] GAL hotkey event handling causing beeps on OSX
-
From:
Wayne Stambaugh <stambaughw@xxxxxxxxx>
-
Date:
Mon, 05 Jan 2015 10:12:51 -0500
-
Cc:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
In-reply-to:
<CAGu=xg3CtJFvcnH4O1b64DDpkxKDKmELW6g_z5AsiHvzZS0P9g@mail.gmail.com>
-
User-agent:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
On 1/5/2015 9:54 AM, Paulo Henrique Silva wrote:
>
> I cannot recall why it has been done that way (maybe wx2.8 issue?).
> Currently the Tool Framework handles the hot keys in its own way, so
> there is a chance that passing the events would not be necessary.
>
> Unfortunately, there is another issue - with the patch applied, one
> cannot draw a selection box in GAL. Does not it happen with OS X?
That's what I was afraid of.
>
>
> Selection box works for me on OSX with patch applied.
>
> Regarding to pass or not the event as Wayne mentions, regular canvas
> appears to do the same as I did on the patch (see common/draw_panel.cpp
> line 1404-1405).
The default canvas checks to see if the event was handled and calls
wxEvent::Skip() if the return from EDA_DRAW_FRAME::GeneralControle()
indicates that it should be skipped. I'm not sure the new tool
framework behavior is the same.
>
> Does anyone actually got the beep on GAL on other platforms? If not I
> can dig a little and check if it something with wxOSX specifically.
No beep on windows 7 pro using kicad r5351 and wx 3.0.2.
>
> Cheers,
>
> -- Paulo
Follow ups
References