kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Simon,

I applied your patch in the product branch r5394.  I generally frown
patches like this.  While technically you are correct EDA_ITEM not used
directly, this is merely semantics.  When this kind of patch is the
biggest issue in the KiCad source, I will retire to some tropical island
and soak up the sun while sipping exotic drinks. :).  I do appreciate
your desire to contribute to KiCad.  If you can fix bugs or improvemen
the documentation and/or libraries, please help out as these
contributions are much needed.  Thank you for your contribution.

Wayne

On 1/25/2015 4:25 PM, Simon Richter wrote:
> This is really an abstract class and should not be instantiated directly.
> ---
>  include/base_struct.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/include/base_struct.h b/include/base_struct.h
> index 360e4ff..5db45f4 100644
> --- a/include/base_struct.h
> +++ b/include/base_struct.h
> @@ -188,11 +188,14 @@ private:
>  
>      void initVars();
>  
> -public:
> +protected:
>  
>      EDA_ITEM( EDA_ITEM* parent, KICAD_T idType );
>      EDA_ITEM( KICAD_T idType );
>      EDA_ITEM( const EDA_ITEM& base );
> +
> +public:
> +
>      virtual ~EDA_ITEM() { };
>  
>      /**
>