kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

That's better.  These two patches resolve the issues so go ahead and
commit them when you get a chance.

Thanks,

Wayne

On 08/07/2015 04:23 AM, Maciej Sumiński wrote:
> True, I forgot there is a second patch (attached).
> 
> Regards,
> Orson
> 
> On 08/07/2015 01:42 AM, Wayne Stambaugh wrote:
>> I'm getting a segfault with or without Orson's patch on Debian Testing
>> so maybe there is something else going on here.
>>
>>
>> On 08/05/2015 03:17 PM, Chris Pavlina wrote:
>>> Regardless of Dick's future plans wrt Python, I do not see why it would 
>>> be desirable to call OnPgmExit inside OnRun instead of inside OnExit. It 
>>> seems clear to me that this is the correct location for it. wx 
>>> documentation and wx source appear to confirm this, as I indicated 
>>> earlier.
>>>
>>> On Wed, Aug 05, 2015 at 10:39:54AM -0400, Wayne Stambaugh wrote:
>>>> On 8/5/2015 10:16 AM, Maciej Sumiński wrote:
>>>>> Chris has pointed out that it was already discussed [1] and the change
>>>>> was not entirely clear. Apparently it had not been wrapped before
>>>>> revision 5834, so maybe OnPgmExit() should be still called for both
>>>>> Python and non-Python versions of pcbnew?
>>>>
>>>> This was done because the problem did not occur when wxPython scripting
>>>> was disabled and Dick is planning on add wxPython on top of Kicad rather
>>>> than a bolted onto the side like our current implementation.
>>>> Compiling OnPgmExit() out of non wxPython builds was at his request.
>>>> The original crash had to do with wxPython clean up not being called
>>>> properly.  I just tried to duplicate this bug on a 32 bit build on
>>>> windows by running 'pcbnew foo` with no scripting enabled, and I cannot
>>>> get it to crash.  Are you testing this on Linux?
>>>>
>>>>>
>>>>> Regards,
>>>>> Orson
>>>>>
>>>>> 1.
>>>>> https://www.mail-archive.com/kicad-developers@xxxxxxxxxxxxxxxxxxx/msg14014.html
>>>>>
>>>>> On 08/05/2015 11:22 AM, Maciej Sumiński wrote:
>>>>>> Pcbnew without scripting support crashes when run with an invalid file
>>>>>> given as a parameter (stack overflow in ~wxSingleInstanceChecker()).
>>>>>>
>>>>>> There is a fix for that, but wrapped with #ifdef
>>>>>> KICAD_SCRIPTING_WXPYTHON .. #endif. I removed the mentioned directives
>>>>>> and it seems fine here, but I am not confident enough to commit it
>>>>>> immediately. Any thoughts?
>>>>>>
>>>>>> Regards,
>>>>>> Orson
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>