← Back to team overview

kicad-developers team mailing list archive

Re: Clipper bugs fixes, suggest for update

 

Le 02/11/2015 13:14, Mário Luzeiro a écrit :
> Hi JP,
> 
> I am not necessarily forcing related it is as a fault from other modules in kicad. But maybe because of any special nature of the polygons from bitmap2component it was causing the issue from that data. (see note*)
> The issue I found in the Clipper is that it was not generate the right polygons after run run the kicad function "simplify". I extract the polygon data,plot it and notice that the polygons are broken, i.e: not correct and not as expected.
> Then I checked Clipper repository and there was this commit:
> http://sourceforge.net/p/polyclipping/code/495/
> "Significant bugfix potentially affecting all clipping ops."
> I then applied the latest version to my branch and it solved the issue I had.
> 
> I notice your commit today, I plan to check it and test it latter today!
> Thanks!
> Mario
> 
> * However, I notice that some polygons have repeated values (special in the latest two positions) but the Append function implemented in Kicad is eliminate this duplication when the data is converted to Clipper.
> Maybe a good thing will be to have a clear / checking the polygons in the origin for more correctness.
> 


OK.

I updated the clipper polygon library in rev 6290.


-- 
Jean-Pierre CHARRAS


References