kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

Did someone propose changing that? I'm confused.

On Wed, May 11, 2016 at 11:05:23AM -0400, Wayne Stambaugh wrote:
> In the Eeschema config file I see:
> 
> SchematicFrameMaxUndoItems=0
> LibeditFrameMaxUndoItems=0
> ViewlibFrameMaxUndoItems=0
> 
> In the Pcbnew config file I see:
> 
> ModEditFrameMaxUndoItems=0
> PcbFrameMaxUndoItems=0
> ModViewFrameMaxUndoItems=0
> 
> 
> This is result of prefixing the frame name to "MaxUndoItem".  I don't
> know why we don't use separate sections for each frame rather than
> prefixing the frame name to the config entry string but we do.  It's
> been that way since I've been with the project and changing it now would
> break everyone's settings.
> 
> On 5/11/2016 10:30 AM, Chris Pavlina wrote:
> > There _is_ no config file entry, unless I'm missing something you can point me
> > to. There was only a global bool flag in pcbnew.h that held the config value, I
> > was not able to find any place that was recorded to disk nor do I see any
> > evidence of it in my config files. Are you sure there is one?
> > 
> > On Wed, May 11, 2016 at 10:54:57AM +0200, Tomasz Wlostowski wrote:
> >> On 10.05.2016 23:41, Chris Pavlina wrote:
> >>> In 6790 I removed the user option to "Dump zone geometry to files when
> >>> filling"; Tom indicated that this was no longer necessary and could be removed.
> >>>
> >>> I left the *code*, however. I took the global flag out of pcbnew.h and replaced
> >>> it with a static const bool in the file where the actual dumping happens, to
> >>> allow this to be switched back on in the future if absolutely necessary.
> >>>
> >>> Particularly @ Tom: should the code be removed as well? How sure are we that
> >>> we'll never need it again? If "mostly sure", I'd advocate for removing it; in
> >>> the unlikely case that that changes we can drag it back out of the rev history.
> >>> If "kinda sure", maybe it can be left in.
> >>>
> >>> What do you think?
> >>>
> >>
> >> I would drop the option from the dialog, but leave the code and the
> >> config file entry (so that it can be enabled by editing the config file
> >> only). Zone filling algorithm still has some rare corner case bugs and
> >> being able to see the intermediate steps of zone filling is a big aid in
> >> fixing them.
> >>
> >> Cheers,
> >> Tom
> >>
> > 
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> > 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp